netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, jeff@garzik.org, gospo@redhat.com,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next PATCH 4/6] igb: misc cleanup to combine one if statement and set last_rx
Date: Thu, 12 Feb 2009 20:18:05 -0800	[thread overview]
Message-ID: <20090213041804.3848.73723.stgit@lost.foo-projects.org> (raw)
In-Reply-To: <20090213041654.3848.39227.stgit@lost.foo-projects.org>

From: Alexander Duyck <alexander.h.duyck@intel.com>

This patch combines a pair of if statements into one and adds a line to
update netdev->last_rx.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/igb/igb_main.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index 5a6bcef..712cfd6 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -2981,9 +2981,9 @@ static int igb_xmit_frame_ring_adv(struct sk_buff *skb,
 
 	if (tso)
 		tx_flags |= IGB_TX_FLAGS_TSO;
-	else if (igb_tx_csum_adv(adapter, tx_ring, skb, tx_flags))
-			if (skb->ip_summed == CHECKSUM_PARTIAL)
-				tx_flags |= IGB_TX_FLAGS_CSUM;
+	else if (igb_tx_csum_adv(adapter, tx_ring, skb, tx_flags) &&
+	         (skb->ip_summed == CHECKSUM_PARTIAL))
+		tx_flags |= IGB_TX_FLAGS_CSUM;
 
 	igb_tx_queue_adv(adapter, tx_ring, tx_flags,
 			 igb_tx_map_adv(adapter, tx_ring, skb, first),
@@ -3886,6 +3886,7 @@ send_up:
 
 		igb_receive_skb(rx_ring, staterr, rx_desc, skb);
 
+		netdev->last_rx = jiffies;
 next_desc:
 		rx_desc->wb.upper.status_error = 0;
 


  parent reply	other threads:[~2009-02-13  4:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13  4:16 [net-next PATCH 1/6] igb: misc whitespace/formatting cleanups Jeff Kirsher
2009-02-13  4:17 ` [net-next PATCH 2/6] igb: reduce size required to trigger low latency Jeff Kirsher
2009-02-16  8:06   ` David Miller
2009-02-13  4:17 ` [net-next PATCH 3/6] igb: cleanup incorrect comment and set IP Checksum Enable Jeff Kirsher
2009-02-16  8:06   ` David Miller
2009-02-13  4:18 ` Jeff Kirsher [this message]
2009-02-13 13:23   ` [net-next PATCH 4/6] igb: misc cleanup to combine one if statement and set last_rx Ben Hutchings
2009-02-14  5:43     ` David Miller
2009-02-13  4:18 ` [net-next PATCH 5/6] igb: remove unused defines Jeff Kirsher
2009-02-16  8:06   ` David Miller
2009-02-13  4:18 ` [net-next PATCH 6/6] igb: transition driver to only using advanced descriptors Jeff Kirsher
2009-02-16  8:07   ` David Miller
2009-02-16  8:06 ` [net-next PATCH 1/6] igb: misc whitespace/formatting cleanups David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213041804.3848.73723.stgit@lost.foo-projects.org \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).