From: Jarek Poplawski <jarkao2@gmail.com>
To: Vlad Yasevich <vladislav.yasevich@hp.com>
Cc: Krzysztof Oledzki <ole@ans.pl>,
Marco Berizzi <pupilla@hotmail.com>,
netdev@vger.kernel.org
Subject: Re: WARNING: at net/core/skbuff.c:154 with tcpdump and ipsec
Date: Fri, 13 Feb 2009 20:24:48 +0100 [thread overview]
Message-ID: <20090213192448.GA2929@ami.dom.local> (raw)
In-Reply-To: <4995C241.1030507@hp.com>
On Fri, Feb 13, 2009 at 01:56:01PM -0500, Vlad Yasevich wrote:
...
> I did notice that pskb_expand_head() doesn't change the skb->truesize even
> though it could grow the skb. I saw this problem with tcpdump while
> experimenting with some SCTP code.
>
> This is not to say that it is the problem in this case, but it's one of
> them that I've seen.
Yes, I've read Herbert Xu's message pointing especially to
xfrm_state_check_space(). So I would like to make sure if there is no
other reason it triggers in packet_recvmsg() on these several reports.
If af_packet code is OK, I guess we could update truesize for it:
there is no reason to warn here about bugs from other, well known
places.
Jarek P.
next prev parent reply other threads:[~2009-02-13 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 15:26 WARNING: at net/core/skbuff.c:154 with tcpdump and ipsec Marco Berizzi
2009-02-11 15:55 ` Krzysztof Oledzki
2009-02-11 18:25 ` Jarek Poplawski
2009-02-13 12:14 ` Jarek Poplawski
2009-02-13 18:56 ` Vlad Yasevich
2009-02-13 19:24 ` Jarek Poplawski [this message]
2009-02-13 19:42 ` Vlad Yasevich
2009-02-13 20:00 ` Jarek Poplawski
2009-02-14 2:24 ` David Miller
2009-02-18 9:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090213192448.GA2929@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ole@ans.pl \
--cc=pupilla@hotmail.com \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).