From: David Miller <davem@davemloft.net>
To: patrick.ohly@intel.com
Cc: johnstul@us.ibm.com, john.ronciak@intel.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH NET-NEXT 0/10] hardware time stamping with new fields in shinfo
Date: Sun, 15 Feb 2009 23:16:26 -0800 (PST) [thread overview]
Message-ID: <20090215.231626.160752710.davem@davemloft.net> (raw)
In-Reply-To: <1234450981.5914.11.camel@ecld0pohly>
From: Patrick Ohly <patrick.ohly@intel.com>
Date: Thu, 12 Feb 2009 16:03:01 +0100
> This revision of the patch series transports hardware time stamps from
> the hardware into user space via additional fields in struct
> skb_shared_info. It's based on net-next-2.6 as of this morning.
>
> This is the solution that emerged from the discussion of the other
> approaches suggested before (reuse tstamp, extend skbuff, optional
> structs): it has the advantage of not touching skbuff and also has the
> simplest implementation.
>
> The clocksource and timecompare patches have been reviewed by John
> Stultz. He doesn't mind merging them via the net subtree.
>
> John Ronciak reviewed the igb driver patches. He suggested to merge the
> patches as they; after all, PTPd already works fine. I just tested again
> on 32 and 64 bit x86, both with the timestamping example programs as
> well as with PTPd. Latest patched PTPd is here:
> http://github.com/pohly/ptpd/tree/master
>
> The open TODOs in the igb driver will be fixed. We think that this will
> be easier with the infrastructure and the driver in a regular kernel
> tree.
Ok, I applied everything and pushed it out to net-next-2.6, let's
see how this goes :-)
That TX clone wrt. skb_orphan() issue will need a happier solution.
Can you describe that problem in detail? Maybe someone can come
up with a way to avoid that stuff.
Thanks.
next prev parent reply other threads:[~2009-02-16 7:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 14:57 [PATCH NET-NEXT 0/10] hardware time stamping with new fields in shinfo Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 01/10] clocksource: allow usage independent of timekeeping.c Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 02/10] timecompare: generic infrastructure to map between two time bases Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 03/10] net: new user space API for time stamping of incoming and outgoing packets Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 04/10] net: infrastructure for hardware time stamping Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 05/10] net: socket infrastructure for SO_TIMESTAMPING Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 06/10] ip: support for TX timestamps on UDP and RAW sockets Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 07/10] net: pass new SIOCSHWTSTAMP through to device drivers Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 08/10] igb: access to NIC time Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 09/10] igb: stub support for SIOCSHWTSTAMP Patrick Ohly
2009-02-12 15:00 ` [PATCH NET-NEXT 10/10] igb: use timecompare to implement hardware time stamping Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 0/10] hardware time stamping with new fields in shinfo Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 01/10] clocksource: allow usage independent of timekeeping.c Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 02/10] timecompare: generic infrastructure to map between two time bases Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 03/10] net: new user space API for time stamping of incoming and outgoing packets Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 04/10] net: infrastructure for hardware time stamping Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 05/10] net: socket infrastructure for SO_TIMESTAMPING Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 06/10] ip: support for TX timestamps on UDP and RAW sockets Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 07/10] net: pass new SIOCSHWTSTAMP through to device drivers Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 08/10] igb: access to NIC time Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 09/10] igb: stub support for SIOCSHWTSTAMP Patrick Ohly
2009-02-12 15:03 ` [PATCH NET-NEXT 10/10] igb: use timecompare to implement hardware time stamping Patrick Ohly
2009-02-16 7:16 ` David Miller [this message]
2009-02-16 7:44 ` [PATCH NET-NEXT 0/10] hardware time stamping with new fields in shinfo Patrick Ohly
2009-02-21 9:15 ` Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090215.231626.160752710.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=john.ronciak@intel.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).