netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Lennert Buytenhek <buytenh@marvell.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/mv643xx: don't disable the mib timer too early
Date: Mon, 16 Feb 2009 09:29:22 +0100	[thread overview]
Message-ID: <20090216082922.GA18030@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <20090215092719.GB12280@Chamillionaire.breakpoint.cc>

* Sebastian Andrzej Siewior | 2009-02-15 10:27:19 [+0100]:

>because mib_counters_update() also restarts the timer.
>So the timer is dequeued, the stats are read and then the timer is
>enqueued again. This is okay, unless someone unloads the module.
I got to NAK that one myself. I make a new one which does not break sth.
else .)

Sebastian

  reply	other threads:[~2009-02-16  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-15  9:27 [PATCH] net/mv643xx: don't disable the mib timer too early Sebastian Andrzej Siewior
2009-02-16  8:29 ` Sebastian Andrzej Siewior [this message]
     [not found]   ` <20090216145610.GX17914@xi.wantstofly.org>
2009-02-16 21:28     ` [PATCH v2] net/mv643xx: don't disable the mib timer too early and lock properly Sebastian Andrzej Siewior
2009-02-19  1:05       ` Lennert Buytenhek
2009-02-19  1:37         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090216082922.GA18030@Chamillionaire.breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=buytenh@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).