From: David Miller <davem@davemloft.net>
To: Santwona.Behera@Sun.COM
Cc: netdev@vger.kernel.org, jeff@garzik.org,
gkernel-commit@lists.sourceforge.net, Matheos.Worku@Sun.COM,
Mehdi.Bonyadi@Sun.COM
Subject: Re: [PATCH 2/3] [kernel] Add support for RX packet classification in a network device
Date: Tue, 17 Feb 2009 20:28:38 -0800 (PST) [thread overview]
Message-ID: <20090217.202838.66382200.davem@davemloft.net> (raw)
In-Reply-To: <49999FA3.7040300@Sun.COM>
From: Santwona.Behera@Sun.COM
Date: Mon, 16 Feb 2009 09:17:23 -0800
> -struct ethtool_rxnfc {
> - __u32 cmd;
> +/* The following structures are for supporting RX network flow
> + * classification configuration. Note, all multibyte fields, e.g.,
> + * ip4src, ip4dst, psrc, pdst, spi, etc. are expected to be in network
> + * byte order.
> + */
> +struct ethtool_tcpip4_spec {
> + __u32 ip4src;
> + __u32 ip4dst;
> + __u16 psrc;
> + __u16 pdst;
> + __u8 tos;
> +};
We have specific types for this, "__be32" et al.
Please use them.
And once you do that properly, checking the code with sparse via "make
C=1" will warn for you if these data items are not accessed as
big-endian items.
next prev parent reply other threads:[~2009-02-18 4:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 17:17 [PATCH 2/3] [kernel] Add support for RX packet classification in a network device Santwona.Behera
2009-02-18 4:28 ` David Miller [this message]
2009-02-18 6:07 ` Harvey Harrison
2009-02-20 8:55 ` David Miller
2009-02-20 17:19 ` [gkernel-commit] " Santwona.Behera
-- strict thread matches above, loose matches on Subject: below --
2009-02-09 23:12 Santwona.Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217.202838.66382200.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matheos.Worku@Sun.COM \
--cc=Mehdi.Bonyadi@Sun.COM \
--cc=Santwona.Behera@Sun.COM \
--cc=gkernel-commit@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).