From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Michael Chan" <mchan@broadcom.com>
Cc: "'Roel Kluin'" <roel.kluin@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Matthew Carlson" <mcarlson@broadcom.com>
Subject: Re: [PATCH] TG3: &&/|| confusion
Date: Tue, 17 Feb 2009 10:34:39 -0800 [thread overview]
Message-ID: <20090217183439.GA7201@xw6200.broadcom.net> (raw)
In-Reply-To: <C27F8246C663564A84BB7AB343977242163420407C@IRVEXCHCCR01.corp.ad.broadcom.com>
On Mon, Feb 16, 2009 at 09:27:19AM -0800, Michael Chan wrote:
> Roel Kluin wrote:
>
> > phyid Can't be both TG3_PHY_OUI_1 and TG3_PHY_OUI_2 and TG3_PHY_OUI_3.
> >
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > // vi drivers/net/tg3.h +2698
> > #define TG3_PHY_OUI_1 0x00206000
> > #define TG3_PHY_OUI_2 0x0143bc00
> > #define TG3_PHY_OUI_3 0x03625c00
> >
> > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> > index 4595962..b080f94 100644
> > --- a/drivers/net/tg3.c
> > +++ b/drivers/net/tg3.c
> > @@ -2237,8 +2237,8 @@ static int tg3_set_power_state(struct
> > tg3 *tp, pci_power_t state)
> > phyid = phydev->drv->phy_id &
> > phydev->drv->phy_id_mask;
> > if (phyid != TG3_PHY_ID_BCMAC131) {
> > phyid &= TG3_PHY_OUI_MASK;
> > - if (phyid == TG3_PHY_OUI_1 &&
> > - phyid == TG3_PHY_OUI_2 &&
> > + if (phyid == TG3_PHY_OUI_1 ||
> > + phyid == TG3_PHY_OUI_2 ||
> > phyid == TG3_PHY_OUI_3)
> > do_low_power = true;
> > }
> >
> >
>
> Thanks, this looks good to me, but I need Matt to ACK this patch.
Yes. This is correct.
Acked-by: Matt Carlson <mcarlson@broadcom.com>
next prev parent reply other threads:[~2009-02-17 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 10:49 [PATCH] TG3: limit reaches -1 Roel Kluin
2009-02-11 20:40 ` Michael Chan
2009-02-13 0:33 ` David Miller
2009-02-15 22:17 ` [PATCH] TG3: &&/|| confusion Roel Kluin
2009-02-16 17:27 ` Michael Chan
2009-02-17 18:34 ` Matt Carlson [this message]
2009-02-19 1:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217183439.GA7201@xw6200.broadcom.net \
--to=mcarlson@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).