* [net-next PATCH] e1000e: remove workaround for e1000 hardware
@ 2009-02-18 9:24 Jeff Kirsher
2009-02-19 3:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2009-02-18 9:24 UTC (permalink / raw)
To: davem; +Cc: netdev, jeff, gospo, Jesse Brandeburg, Bruce Allan, Jeff Kirsher
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
During the move of support for PCIe devices from e1000 to e1000e, this workaround necessary only for older non-PCIe devices was mistakenly copied into e1000e. Remove it.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Acked-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e1000e/netdev.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 04e007d..1b5a0c8 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -3831,11 +3831,6 @@ static int e1000_tx_map(struct e1000_adapter *adapter,
buffer_info = &tx_ring->buffer_info[i];
size = min(len, max_per_txd);
- /* Workaround for premature desc write-backs
- * in TSO mode. Append 4-byte sentinel desc */
- if (mss && !nr_frags && size == len && size > 8)
- size -= 4;
-
buffer_info->length = size;
/* set time_stamp *before* dma to help avoid a possible race */
buffer_info->time_stamp = jiffies;
@@ -3869,10 +3864,6 @@ static int e1000_tx_map(struct e1000_adapter *adapter,
while (len) {
buffer_info = &tx_ring->buffer_info[i];
size = min(len, max_per_txd);
- /* Workaround for premature desc write-backs
- * in TSO mode. Append 4-byte sentinel desc */
- if (mss && f == (nr_frags-1) && size == len && size > 8)
- size -= 4;
buffer_info->length = size;
buffer_info->time_stamp = jiffies;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next PATCH] e1000e: remove workaround for e1000 hardware
2009-02-18 9:24 [net-next PATCH] e1000e: remove workaround for e1000 hardware Jeff Kirsher
@ 2009-02-19 3:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-19 3:34 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, jeff, gospo, jesse.brandeburg, bruce.w.allan
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 18 Feb 2009 01:24:51 -0800
> During the move of support for PCIe devices from e1000 to e1000e,
> this workaround necessary only for older non-PCIe devices was
> mistakenly copied into e1000e. Remove it.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-19 3:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-18 9:24 [net-next PATCH] e1000e: remove workaround for e1000 hardware Jeff Kirsher
2009-02-19 3:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).