From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: net_device_ops support in bridging and fec_mpc52xx.c Date: Wed, 18 Feb 2009 14:31:16 -0800 Message-ID: <20090218143116.69948299@extreme> References: <20090218.134852.118040610.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: henk.stegeman@gmail.com, linuxppc-dev@ozlabs.org, bridge@osdl.org, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail.vyatta.com ([76.74.103.46]:50910 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754543AbZBRWbT (ORCPT ); Wed, 18 Feb 2009 17:31:19 -0500 In-Reply-To: <20090218.134852.118040610.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 18 Feb 2009 13:48:52 -0800 (PST) David Miller wrote: > From: Henk Stegeman > Date: Wed, 18 Feb 2009 11:41:14 +0100 > > Please CC: netdev, now added, on all networking reports and patches. > > Thank you. > > > I discovered the hard way that because linux bridging uses > > net_device_ops, bridging only works with network drivers that publish > > their device operations trough net_device_ops. > > > > In my case running: > > > > brctl addif br0 eth0 (where eth0 fec_mpc52xx.c did not yet support > > net_device_ops) gave me a: > > > > Unable to handle kernel paging request... > > > > After changing fec_mpc52xx.c to support net_device_ops the problem was fixed. > > > > If possible some kind of detection in the bridging software is i think > > mostly appreciated for early detection of this problem, as it is > > pretty hard to relate the error message to a not updated driver. > > > > cheers, > > > > Henk The normal register_netdevice stuff take care of setting up net_device_ops for old style drivers. Was there something different about how this device was being setup?