netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Greg Ungerer <gerg@snapgear.com>
Cc: gerg@uclinux.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] fec: move ColdFire setup code out of FEC driver
Date: Wed, 18 Feb 2009 17:42:57 +0100	[thread overview]
Message-ID: <20090218164257.GI2089@pengutronix.de> (raw)
In-Reply-To: <200902170053.n1H0r1WP002062@localhost.localdomain>

Hi Greg,

On Tue, Feb 17, 2009 at 10:53:01AM +1000, Greg Ungerer wrote:
> 
> Hi Sascha,
> 
> The following 2 patches move the ColdFire specific FEC setup code
> into the ColdFire CPU platform setup code.

Looks good to me, though I can't apply them. To which tree should
they apply?

> 
> There is still a little remaining legacy code that needs taking
> care of in fec.c. The flash reading MAC setup code and the MII
> link interrupts of the 5272 are still in there.

maybe the board setup code could copy the MAC Address from the
flash directly to the device. The driver will pick it up from
there.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2009-02-18 16:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17  0:53 [PATCH 0/2] fec: move ColdFire setup code out of FEC driver Greg Ungerer
2009-02-18 16:42 ` Sascha Hauer [this message]
2009-02-18 21:53   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090218164257.GI2089@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=gerg@snapgear.com \
    --cc=gerg@uclinux.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).