From: Stephen Hemminger <shemminger@vyatta.com>
To: "Srivats P" <Srivats.P@conexant.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] iproute2: Fix no default display of ip4ip6 tunnels
Date: Thu, 19 Feb 2009 08:52:09 -0800 [thread overview]
Message-ID: <20090219085209.4dc6bce5@extreme> (raw)
In-Reply-To: <F33E0C3C2876A544ABD34CFBE345A4A40211E426D0@NDMBX01.bbnet.ad>
On Thu, 19 Feb 2009 12:06:33 +0530
"Srivats P" <Srivats.P@conexant.com> wrote:
> From: Srivats P. <srivats.p@conexant.com>
>
> "ip -6 tunnel show" displays only ip6ip6 tunnels not ip4ip6 tunnels - it should display all irrespective of proto.
>
> This is because the default tunnel proto is initialized to IPPROTO_IPV6 in ip6_tnl_parm_init() which is fine for a 'add' command but not for 'show'. This patch overrides proto with 0 signifying 'mode any' as the default in case of a 'show'.
>
> Signed-off-by: Srivats P. <srivats.p@conexant.com>
> ---
>
> diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c
> index 8421983..0122974 100644
> --- a/ip/ip6tunnel.c
> +++ b/ip/ip6tunnel.c
> @@ -335,6 +335,7 @@ static int do_show(int argc, char **argv)
> struct ip6_tnl_parm p;
>
> ip6_tnl_parm_init(&p, 0);
> + p.proto = 0;
>
> if (parse_args(argc, argv, &p) < 0)
> return -1;
>
it is possible to see all with
ip -6 tunnel show mode all
next prev parent reply other threads:[~2009-02-19 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 6:36 [PATCH] iproute2: Fix no default display of ip4ip6 tunnels Srivats P
2009-02-19 16:52 ` Stephen Hemminger [this message]
2009-02-20 4:49 ` Srivats P
2009-02-24 8:51 ` Srivats P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219085209.4dc6bce5@extreme \
--to=shemminger@vyatta.com \
--cc=Srivats.P@conexant.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).