* [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it.
@ 2009-01-27 3:20 Jeff Kirsher
2009-02-10 1:02 ` Jeff Kirsher
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Kirsher @ 2009-01-27 3:20 UTC (permalink / raw)
To: shemminger; +Cc: netdev, davem, jeff, Alexander Duyck, Jeff Kirsher
From: Alexander Duyck <alexander.h.duyck@intel.com>
A bug was found in which the memory for the tc_skbedit struct was being
used uninitialized to 0. This patch corrects the issue by using a memset
to 0 out the memory of the structure.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
tc/m_skbedit.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 55e3f89..0e50fbc 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -57,6 +57,8 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
__u16 queue_mapping;
__u32 flags = 0, priority;
+ memset(&sel, 0, sizeof(struct tc_skbedit));
+
if (matches(*argv, "skbedit") != 0)
return -1;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it.
2009-01-27 3:20 [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it Jeff Kirsher
@ 2009-02-10 1:02 ` Jeff Kirsher
2009-02-19 17:00 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Kirsher @ 2009-02-10 1:02 UTC (permalink / raw)
To: shemminger; +Cc: netdev, davem, jeff, Alexander Duyck, Jeff Kirsher
Stephen - what is the status of this?
--
Cheers,
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it.
2009-02-10 1:02 ` Jeff Kirsher
@ 2009-02-19 17:00 ` Stephen Hemminger
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2009-02-19 17:00 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: netdev, davem, jeff, Alexander Duyck, Jeff Kirsher
On Mon, 9 Feb 2009 17:02:48 -0800
Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> Stephen - what is the status of this?
>
Similar fix just applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-19 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-27 3:20 [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it Jeff Kirsher
2009-02-10 1:02 ` Jeff Kirsher
2009-02-19 17:00 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).