Re: [PATCH 4/8] can: Driver for the SJA1000 CAN controller

[David Miller <davem@davemloft.net>]

From: Jonathan Corbet <corbet@lwn.net>
Date: Thu, 19 Feb 2009 17:14:40 -0700

> I won't be able to look at all of these...
> 
> > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> > index d609895..78a412b 100644
> > --- a/drivers/net/can/Kconfig
> > +++ b/drivers/net/can/Kconfig
> > @@ -35,6 +35,17 @@ config CAN_CALC_BITTIMING
> >  	  files "tq", "prop_seg", "phase_seg1", "phase_seg2" and "sjw".
> >  	  If unsure, say Y.
> >  
> > +config CAN_SJA1000
> > +	depends on CAN_DEV
> > +	tristate "Philips SJA1000"
> > +	---help---
> > +	  The SJA1000 is one of the top CAN controllers out there. As it
> > +	  has a multiplexed interface it fits directly to 8051
> > +	  microcontrollers or into the PC I/O port space. The SJA1000
> > +	  is a full CAN controller, with shadow registers for RX and TX.
> > +	  It can send and receive any kinds of CAN frames (SFF/EFF/RTR)
> > +	  with a single (simple) filter setup.
> 
> This sounds more like advertising text.  But what people need to know is
> whether they should enable it or not.

Totally agreed, this Kconfig help text is inappropriate
at best.