netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: pablo@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: add NETLINK_BROADCAST_ERROR socket option
Date: Fri, 20 Feb 2009 01:01:29 -0800 (PST)	[thread overview]
Message-ID: <20090220.010129.217009353.davem@davemloft.net> (raw)
In-Reply-To: <499BF468.5010406@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Wed, 18 Feb 2009 12:43:36 +0100

> Pablo Neira Ayuso wrote:
> > This patch adds NETLINK_BROADCAST_ERROR which is a netlink
> > socket option that the listener can set to make netlink_broadcast()
> > return errors in the delivery to the caller. This option is useful
> > if the caller of netlink_broadcast() do something with the result
> > of the message delivery, like in ctnetlink where it drops a network
> > packet if the event delivery failed, this is used to enable reliable
> > logging and state-synchronization. If this socket option is not set,
> > netlink_broadcast() only reports ESRCH errors and silently ignore
> > ENOBUFS errors, which is what most netlink_broadcast() callers
> > should do.
> > This socket option is based on a suggestion from Patrick McHardy.
> > Patrick McHardy can exchange this patch for a beer from me ;).
> 
> I'd accept that offer, but it needs to go through Dave :)
> Anyways, the patch looks good.
> 
> Acked-by: Patrick McHardy <kaber@trash.net>

Applied, thanks guys.

  reply	other threads:[~2009-02-20  9:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18 11:40 [PATCH] netlink: add NETLINK_BROADCAST_ERROR socket option Pablo Neira Ayuso
2009-02-18 11:43 ` Patrick McHardy
2009-02-20  9:01   ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-02-17 13:56 Pablo Neira Ayuso
2009-02-17 14:18 ` Patrick McHardy
2009-02-17 15:45   ` Pablo Neira Ayuso
2009-02-17 15:52     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220.010129.217009353.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).