netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 2/2] snap: handle registration error and compile warning
Date: Fri, 20 Feb 2009 10:03:02 -0800	[thread overview]
Message-ID: <20090220100302.561dcfab@extreme> (raw)
In-Reply-To: <20090220100206.533d59d4@extreme>

If this module can't load, it is almost certainly because something else
is already bound to that SAP. So in that case, return the same error code
as other SAP usage, and fail the module load.

Also fixes a compiler warning about printk of non const.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--- a/net/802/psnap.c	2009-02-20 08:38:04.545372306 -0800
+++ b/net/802/psnap.c	2009-02-20 08:39:16.394961522 -0800
@@ -95,15 +95,16 @@ static int snap_request(struct datalink_
 EXPORT_SYMBOL(register_snap_client);
 EXPORT_SYMBOL(unregister_snap_client);
 
-static char snap_err_msg[] __initdata =
+static const char snap_err_msg[] __initconst =
 	KERN_CRIT "SNAP - unable to register with 802.2\n";
 
 static int __init snap_init(void)
 {
 	snap_sap = llc_sap_open(0xAA, snap_rcv);
-
-	if (!snap_sap)
+	if (!snap_sap) {
 		printk(snap_err_msg);
+		return -EBUSY;
+	}
 
 	return 0;
 }

  reply	other threads:[~2009-02-20 18:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 18:02 [PATCH 1/2] llc: fix non-const printk warning Stephen Hemminger
2009-02-20 18:03 ` Stephen Hemminger [this message]
2009-02-20 21:37   ` [PATCH 2/2] snap: handle registration error and compile warning Arnaldo Carvalho de Melo
2009-02-22  8:03     ` David Miller
2009-02-20 21:37 ` [PATCH 1/2] llc: fix non-const printk warning Arnaldo Carvalho de Melo
2009-02-22  8:02   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220100302.561dcfab@extreme \
    --to=shemminger@vyatta.com \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).