From: David Miller <davem@davemloft.net>
To: brian.haley@hp.com
Cc: arvidjaar@mail.ru, vladislav.yasevich@hp.com,
chuck.lever@oracle.com, tytso@mit.edu, Valdis.Kletnieks@vt.edu,
rjw@sisk.pl, netdev@vger.kernel.org,
bonding-devel@lists.sourceforge.net, jamagallon@ono.com,
linux-kernel@vger.kernel.org, fubar@us.ibm.com
Subject: Re: [PATCH] bonding: move IPv6 support into a separate kernel module
Date: Sat, 21 Feb 2009 23:59:01 -0800 (PST) [thread overview]
Message-ID: <20090221.235901.244910753.davem@davemloft.net> (raw)
In-Reply-To: <499F4B61.3050508@hp.com>
From: Brian Haley <brian.haley@hp.com>
Date: Fri, 20 Feb 2009 19:31:29 -0500
> [Possible fix for bonding IPv6 regression reported by Andrey Borzenkov,
> tried to keep all Cc's]
>
> This patch moves the IPv6 bonding code into a separate kernel module
> called bonding_ipv6 if either bonding or IPv6 are built as modules.
> If both are built into the kernel then this is as well. Bonding_ipv6.ko
> registers an "send_unsol_na" function pointer for the unsolicited
> advertisement function to be called on a failover - the default action
> is to do nothing. The notifier callbacks are now registered in this
> module and not in the base bonding module.
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
Thanks for taking the time to work on this Brian.
I wonder if we aren't just trading one evil for another.
Right now just configuring bonding will get the bonding
module loaded and the ipv6 facilities will be visible.
Now with your change, the user has to explicitly load
the module. That's extremely user-unfriendly.
next prev parent reply other threads:[~2009-02-22 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 0:31 [PATCH] bonding: move IPv6 support into a separate kernel module Brian Haley
2009-02-22 7:59 ` David Miller [this message]
2009-02-22 8:27 ` Willy Tarreau
2009-02-23 14:25 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090221.235901.244910753.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=arvidjaar@mail.ru \
--cc=bonding-devel@lists.sourceforge.net \
--cc=brian.haley@hp.com \
--cc=chuck.lever@oracle.com \
--cc=fubar@us.ibm.com \
--cc=jamagallon@ono.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tytso@mit.edu \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).