From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugene Teo Subject: net: amend the fix for SO_BSDCOMPAT gsopt infoleak Date: Tue, 24 Feb 2009 00:41:12 +0800 Message-ID: <20090223164112.GA29425@kernel.sg> Reply-To: Eugene Teo Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mpatocka@redhat.com To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from mx2.redhat.com ([66.187.237.31]:57946 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754541AbZBWQlT (ORCPT ); Mon, 23 Feb 2009 11:41:19 -0500 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: The fix for CVE-2009-0676 (upstream commit df0bca04) is incomplete. Note that the same problem of leaking kernel memory will reappear if someone on some architecture uses struct timeval with some internal padding (for example tv_sec 64-bit and tv_usec 32-bit) --- then, you are going to leak the padded bytes to userspace. Signed-off-by: Eugene Teo Reported-by: Mikulas Patocka diff --git a/net/core/sock.c b/net/core/sock.c index 6f2e133..913c95f 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -696,7 +696,7 @@ int sock_getsockopt(struct socket *sock, int level, int optname, if (len < 0) return -EINVAL; - v.val = 0; + memset(&v, 0, sizeof(v)); switch(optname) { case SO_DEBUG: