From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
jesse.brandeburg@intel.com, leitao@linux.vnet.ibm.com
Subject: Re: [net-next PATCH 2/2] ixbge: fix bug when using large pages and jumbo frames
Date: Tue, 24 Feb 2009 16:37:41 -0800 (PST) [thread overview]
Message-ID: <20090224.163741.23168667.davem@davemloft.net> (raw)
In-Reply-To: <20090224234056.29312.78842.stgit@lost.foo-projects.org>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 24 Feb 2009 15:40:56 -0800
> it was pointed out on the list that ixgbe was failing when using 64kB pages
> and large 16kB MTU.
>
> since with a 64kB PAGE_SIZE MAX_SKB_FRAGS = 3, the way the driver was
> configuring page usage was assuming 2kB is half a page, and was only
> ever dmaing that much data to a half page.
>
> (16kB - header size) / 2048 = 7 or 8 pages, which would far exceed 3
>
> adjust the driver to account for these large pages, the hardware can
> support DMA to up to 16kB for each descriptor.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2009-02-25 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 23:40 [net-next PATCH 1/2] ixgbe: Move ring features into an enum, allowing easier future maintenance Jeff Kirsher
2009-02-24 23:40 ` [net-next PATCH 2/2] ixbge: fix bug when using large pages and jumbo frames Jeff Kirsher
2009-02-25 0:37 ` David Miller [this message]
2009-02-25 0:37 ` [net-next PATCH 1/2] ixgbe: Move ring features into an enum, allowing easier future maintenance David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224.163741.23168667.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).