From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: rdreier@cisco.com, snakebyte@gmx.de, netdev@vger.kernel.org,
yoshfuji@linux-ipv6.org
Subject: Re: Deadlock with icmpv6fuzz
Date: Tue, 24 Feb 2009 23:44:01 -0800 (PST) [thread overview]
Message-ID: <20090224.234401.257258567.davem@davemloft.net> (raw)
In-Reply-To: <20090209050354.GA3548@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 9 Feb 2009 16:03:54 +1100
> David Miller <davem@davemloft.net> wrote:
> >
> > But some apps might start breaking since this would now
> > charge the socket and we could hit the limits whereas
> > before we wouldn't.
>
> Yes we should definitely test this carefully.
>
> However, I think it is the right thing to do since we shouldn't
> leave holes where the user can allocate kernel memory that is
> uncapped.
>
> In fact, a number of spots in IPv6 already use sock_kmalloc
> for these objects anyway (e.g., ipv6_dup_options in exthdrs.c)
> so there is no fundamental reason why this limit can't be imposed.
Actually it turns out we can't do that here. This flow label object
is global, rather than specifically associated with a given socket.
See net/ipv6/ip6_flowlabel.c:fl_{create,intern}() and how those
are used.
next prev parent reply other threads:[~2009-02-25 7:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 20:47 Deadlock with icmpv6fuzz Eric Sesterhenn
2009-01-27 5:31 ` David Miller
2009-01-27 7:53 ` Eric Sesterhenn
2009-01-28 9:35 ` Herbert Xu
2009-01-30 1:49 ` David Miller
2009-02-05 13:01 ` Herbert Xu
2009-02-05 14:31 ` Eric Sesterhenn
2009-02-05 22:24 ` Roland Dreier
2009-02-05 23:43 ` Herbert Xu
2009-02-06 8:50 ` David Miller
2009-02-06 8:54 ` Herbert Xu
2009-02-06 9:05 ` David Miller
2009-02-06 9:22 ` Herbert Xu
2009-02-06 9:27 ` David Miller
2009-02-06 10:27 ` Herbert Xu
2009-02-06 10:34 ` Herbert Xu
2009-02-06 11:07 ` David Miller
2009-02-09 5:03 ` Herbert Xu
2009-02-09 6:04 ` David Miller
2009-02-25 7:44 ` David Miller [this message]
2009-02-25 8:25 ` Herbert Xu
2009-02-06 11:05 ` David Miller
2009-02-05 23:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224.234401.257258567.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=snakebyte@gmx.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).