netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: herbert@gondor.apana.org.au, shemminger@vyatta.com,
	netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
	jmorris@namei.org, yoshfuji@linux-ipv6.org
Subject: Re: [RFC] addition of a dropped packet notification service
Date: Wed, 25 Feb 2009 04:01:30 -0800 (PST)	[thread overview]
Message-ID: <20090225.040130.169376412.davem@davemloft.net> (raw)
In-Reply-To: <20090225115419.GA16150@hmsreliant.think-freely.org>

From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 25 Feb 2009 06:54:19 -0500

> I had actually started down this road for awhile, and liked it for
> its low maintenence overhead (as you mentioned, less to annotate),
> but I balked at it after a bit, mostly for its increased ambiguity.
> By catching the drop where the packet is freed, we lose information
> about the exact point at which we decided to drop it.  As such,
> users of said dumped table loose (or potentially lose) the ability
> to correlate the saved stack pointer with an exact point in the code
> where a corresponding statistic was incremented, as well as the
> correlation to a specific point in the code (they just get the
> calling function program counter rather than file, funciton and line
> number).

Userland tools can extract this information from a non-stripped
kernel image file, given just a kernel PC value.

And you need the same thing to extract the same information
if you used tracepoints.

  reply	other threads:[~2009-02-25 12:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06 18:20 [RFC] addition of a dropped packet notification service Neil Horman
2009-02-07  0:57 ` Stephen Hemminger
2009-02-07 17:49   ` Neil Horman
2009-02-09 10:21     ` Herbert Xu
2009-02-09 13:28       ` Neil Horman
2009-02-25  7:48       ` David Miller
2009-02-25  8:16         ` Herbert Xu
2009-02-25 11:54         ` Neil Horman
2009-02-25 12:01           ` David Miller [this message]
2009-02-25 14:18             ` Neil Horman
2009-02-25 22:07               ` David Miller
2009-02-26  0:01                 ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225.040130.169376412.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jmorris@namei.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=pekkas@netcore.fi \
    --cc=shemminger@vyatta.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).