From: Hannes Eder <hannes@hanneseder.net>
To: netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] drivers/isdn/act2000: fix sparse warning: symbol shadows an earlier one
Date: Thu, 26 Feb 2009 00:09:52 +0100 [thread overview]
Message-ID: <20090225230848.5377.12920.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090225230737.5377.31370.stgit@localhost.localdomain>
Impact: Rename local variable 'c' to 't'.
Fix this sparse warning:
drivers/isdn/act2000/act2000_isa.c:260:70: warning: symbol 'c' shadows an earlier one
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
The lines are overlong, but the whole function would need a good
reformating / refactoring in order to obey the 80 character limit.
drivers/isdn/act2000/act2000_isa.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/isdn/act2000/act2000_isa.c b/drivers/isdn/act2000/act2000_isa.c
index 1bd8960..fea5b78 100644
--- a/drivers/isdn/act2000/act2000_isa.c
+++ b/drivers/isdn/act2000/act2000_isa.c
@@ -257,9 +257,9 @@ act2000_isa_receive(act2000_card *card)
printk(KERN_WARNING
"act2000_isa_receive: Invalid CAPI msg\n");
{
- int i; __u8 *p; __u8 *c; __u8 tmp[30];
- for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, c = tmp; i < 8; i++)
- c += sprintf(c, "%02x ", *(p++));
+ int i; __u8 *p; __u8 *t; __u8 tmp[30];
+ for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i < 8; i++)
+ t += sprintf(t, "%02x ", *(p++));
printk(KERN_WARNING "act2000_isa_receive: %s\n", tmp);
}
}
next prev parent reply other threads:[~2009-02-25 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 23:08 [PATCH 0/5] drivers/isdn: fix sparse warnings Hannes Eder
2009-02-25 23:08 ` [PATCH 1/5] drivers/isdn/capi: fix sparse warning: context imbalance Hannes Eder
2009-02-25 23:09 ` Hannes Eder [this message]
2009-02-25 23:11 ` [PATCH 3/5] drivers/isdn/hisax: fix sparse warning: Should it be static? Hannes Eder
2009-02-25 23:11 ` [PATCH 4/5] drivers/isdn/hardware/icon: fix sparse warning: cast truncates bits Hannes Eder
2009-02-25 23:11 ` [PATCH 5/5] drivers/isdn/hardware/eicon: fix sparse warnings: Should it be static? Hannes Eder
2009-02-27 9:01 ` [PATCH 0/5] drivers/isdn: fix sparse warnings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225230848.5377.12920.stgit@localhost.localdomain \
--to=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox