From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: roel.kluin@gmail.com, netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] tcp: '< 0' test on unsigned
Date: Sun, 01 Mar 2009 20:36:43 -0800 (PST) [thread overview]
Message-ID: <20090301.203643.105143832.davem@davemloft.net> (raw)
In-Reply-To: <20090302043056.GA16090@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 2 Mar 2009 12:30:56 +0800
> Roel Kluin <roel.kluin@gmail.com> wrote:
> >
> > diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
> > index 25524d4..0b9d63f 100644
> > --- a/net/ipv4/tcp_probe.c
> > +++ b/net/ipv4/tcp_probe.c
> > @@ -167,7 +167,7 @@ static ssize_t tcpprobe_read(struct file *file, char __user *buf,
> > {
> > int error = 0, cnt = 0;
> >
> > - if (!buf || len < 0)
> > + if (!buf || (ssize_t)len < 0)
> > return -EINVAL;
> >
> > while (cnt < len) {
>
> Either cnt needs to be promoted, or you need to limit len to INT_MAX.
Right, since the positive range of 'size_t' can exceed that of 'int'
next prev parent reply other threads:[~2009-03-02 4:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 21:09 [PATCH] tcp: '< 0' test on unsigned Roel Kluin
2009-03-02 4:30 ` Herbert Xu
2009-03-02 4:36 ` David Miller [this message]
2009-03-02 12:24 ` Roel Kluin
2009-03-13 23:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090301.203643.105143832.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).