From: David Miller <davem@davemloft.net>
To: ithilgore.ryu.l@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: PATCH tcp_init_wl / tcp_update_wl argument cleanup
Date: Mon, 02 Mar 2009 03:14:01 -0800 (PST) [thread overview]
Message-ID: <20090302.031401.177327405.davem@davemloft.net> (raw)
In-Reply-To: <49AA657B.5030904@gmail.com>
From: "ithilgore.ryu.L@gmail.com" <ithilgore.ryu.l@gmail.com>
Date: Sun, 01 Mar 2009 12:37:47 +0200
> The above functions from include/net/tcp.h have been defined with an
> argument that they never use. The argument is 'u32 ack' which is never
> used inside the function body, and thus it can be removed. The rest of
> the patch involves the necessary changes to the function callers of the
> above two functions.
Please read linux/Documentation/SubmittingPatches
In particular, your submission:
1) Lacked a proper "Signed-off-by" line and please do fix
the proper name assosciated with your email address if
you don't mind.
2) Did not root your patch properly.
Thanks.
next prev parent reply other threads:[~2009-03-02 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 10:37 PATCH tcp_init_wl / tcp_update_wl argument cleanup ithilgore.ryu.L@gmail.com
2009-03-02 11:14 ` David Miller [this message]
2009-03-02 17:57 ` Hantzis Fotis
2009-03-03 6:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302.031401.177327405.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ithilgore.ryu.l@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).