netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: acme@redhat.com
Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org,
	kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs
Date: Wed, 04 Mar 2009 14:47:22 -0800 (PST)	[thread overview]
Message-ID: <20090304.144722.167821808.davem@davemloft.net> (raw)
In-Reply-To: <20090304224505.GD6392@ghostprotocols.net>

From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Wed, 4 Mar 2009 19:45:05 -0300

> hasta_la_vista_skbaby()

This is my personal favorite, it's very Mexifornia.

> consumed_skb()

But more seriously I like something like "consume_skb()" the best (ie.
drop the 'd').  It has the implication that an application or other
entity "consumed" and used the data before we freed the SKB.

What do you think?

  reply	other threads:[~2009-03-04 22:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 17:03 [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs Neil Horman
2009-03-04 13:54 ` Arnaldo Carvalho de Melo
2009-03-04 14:18   ` Neil Horman
2009-03-04 16:13     ` Arnaldo Carvalho de Melo
2009-03-04 21:06       ` David Miller
2009-03-04 22:45         ` Arnaldo Carvalho de Melo
2009-03-04 22:47           ` David Miller [this message]
2009-03-04 22:51             ` Arnaldo Carvalho de Melo
2009-03-04 23:57             ` Patrick McHardy
2009-03-05 21:01 ` Neil Horman
2009-03-11 16:18   ` David Miller
2009-03-11 16:34     ` Eric Dumazet
2009-03-11 16:48       ` David Miller
2009-03-11 17:07       ` Neil Horman
2009-03-11 21:39         ` Evgeniy Polyakov
2009-03-12  0:30           ` Neil Horman
2009-03-11 19:49 ` Neil Horman
2009-03-13 19:10   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090304.144722.167821808.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=acme@redhat.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=pekkas@netcore.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).