From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs Date: Wed, 4 Mar 2009 10:54:15 -0300 Message-ID: <20090304135415.GB6392@ghostprotocols.net> References: <20090303170307.GD1480@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net To: Neil Horman Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38296 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbZCDNzT (ORCPT ); Wed, 4 Mar 2009 08:55:19 -0500 Content-Disposition: inline In-Reply-To: <20090303170307.GD1480@hmsreliant.think-freely.org> Sender: netdev-owner@vger.kernel.org List-ID: Em Tue, Mar 03, 2009 at 12:03:07PM -0500, Neil Horman escreveu: > > Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs > Signed-off-by: Neil Horman Why just not add a "drop_skb()" instead? kfree_skb_clean sounds as if we will do some cleanup on the skb being freed. "drop_skb()" seems much clearer. - Arnaldo