From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Yinghai Lu <yinghai@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Matthew Wilcox <matthew@wil.cx>,
Jesse Brandeburg <jesse.brandeburg@gmail.com>,
David Miller <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
NetDev <netdev@vger.kernel.org>,
linux-pci@vger.kernel.org,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] pci: fix kexec with power state D3
Date: Sun, 8 Mar 2009 11:15:30 +0100 [thread overview]
Message-ID: <20090308101530.GB14133@elte.hu> (raw)
In-Reply-To: <200903081108.24541.rjw@sisk.pl>
* Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Sunday 08 March 2009, Yinghai Lu wrote:
> >
> > Impact: second kernel by kexec will have some pci devices working
> >
> > Found one system with 82575EB, in the kernel that is kexeced, probe igb
> > failed with -2.
> >
> > it looks like the same behavior happened on forcedeth.
> > try to check system_state to make sure if put it on D3
>
> This is not enough, because the PM code doesn't change
> system_state and it uses pci_set_power_state too.
>
> > Jesse Brandeburg said that we should do that check in core
> > code instead of every device driver.
>
> Well, I'm not really sure. The drivers are where the bug is.
So Yinghai has now written a driver fix and a generic code fix
as well and both are being rejected pointing to the other side?
This really sucks for users (who'd be happy with any of the
patches) and the disagreement needs to be resolved ASAP.
Ingo
next prev parent reply other threads:[~2009-03-08 10:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 4:33 [PATCH] igb: fix kexec with igb Yinghai Lu
2009-03-07 7:18 ` Jesse Brandeburg
2009-03-07 7:31 ` Yinghai Lu
2009-03-07 18:20 ` Eric W. Biederman
2009-03-07 18:50 ` Yinghai Lu
2009-03-08 10:45 ` Rafael J. Wysocki
2009-03-08 10:57 ` Rafael J. Wysocki
2009-03-08 18:03 ` Yinghai Lu
2009-03-08 18:10 ` Yinghai Lu
2009-03-08 21:08 ` Rafael J. Wysocki
2009-03-08 21:18 ` Yinghai Lu
2009-03-08 21:40 ` Rafael J. Wysocki
2009-03-08 21:32 ` Rafael J. Wysocki
2009-03-08 22:35 ` Yinghai Lu
2009-03-08 22:57 ` Rafael J. Wysocki
2009-03-08 23:04 ` Yinghai Lu
2009-03-08 23:57 ` Rafael J. Wysocki
2009-03-11 23:37 ` Yinghai Lu
2009-03-21 22:04 ` [Updated patch] " Rafael J. Wysocki
2009-03-24 22:35 ` Yinghai Lu
2009-03-28 21:27 ` Rafael J. Wysocki
2009-03-29 2:30 ` Jeff Kirsher
2009-03-29 11:19 ` Rafael J. Wysocki
2009-03-30 21:36 ` Jeff Kirsher
2009-03-30 21:39 ` Rafael J. Wysocki
2009-03-31 19:14 ` Tantilov, Emil S
2009-03-31 19:51 ` Jeff Kirsher
2009-03-31 20:27 ` Rafael J. Wysocki
2009-03-08 8:09 ` [PATCH] pci: fix kexec with power state D3 Yinghai Lu
2009-03-08 10:08 ` Rafael J. Wysocki
2009-03-08 10:15 ` Ingo Molnar [this message]
2009-03-08 10:28 ` Rafael J. Wysocki
2009-03-08 10:33 ` Rafael J. Wysocki
2009-03-08 11:08 ` Ingo Molnar
2009-03-20 1:49 ` Jesse Barnes
2009-03-20 11:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090308101530.GB14133@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=jesse.brandeburg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).