From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: netdev@vger.kernel.org, linux-driver@qlogic.com
Subject: Re: [net-next PATCH0/12] qlge: More features and cleanup.
Date: Tue, 10 Mar 2009 04:46:03 -0700 (PDT) [thread overview]
Message-ID: <20090310.044603.190103058.davem@davemloft.net> (raw)
In-Reply-To: <1236632368-22079-1-git-send-email-ron.mercer@qlogic.com> <1236632368-22079-6-git-send-email-ron.mercer@qlogic.com>
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Mon, 9 Mar 2009 13:59:16 -0700
> Attached are more qlge patches for adding features such as multi TXQ and
> LRO.
> I've also included 4 bug fixes, 3 of which I will also post to net-2.6
> in a separate series tomorrow.
All applied, thanks Ron, although one thing I think you should
get rid of:
> @@ -3354,6 +3351,7 @@ static int ql_configure_rings(struct ql_adapter *qdev)
> * completion handler rx_rings.
> */
> qdev->rx_ring_count = qdev->tx_ring_count + qdev->rss_ring_count + 1;
> + netif_set_gso_max_size(qdev->ndev, 65536);
>
> for (i = 0; i < qdev->tx_ring_count; i++) {
> tx_ring = &qdev->tx_ring[i];
65536 (defined by GSO_MAX_SIZE) is the default and it's really a good
idea to only use this override interface on chips that actaully have
restrictions and can't use the default.
I also don't see what this change had to do with adding TX
multiqueue support :-) It wasn't mentioned in the commit log
message in any way either. Please don't slip small things in
like this.
next prev parent reply other threads:[~2009-03-10 11:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 20:59 [net-next PATCH0/12] qlge: More features and cleanup Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 01/12] qlge: Move reset logic into asic_reset_worker func Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 02/12] qlge: Remove debug junk from asic reset logic Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 03/12] qlge: Increase filtering for inbound csum settings Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 04/12] qlge: Add support for GRO Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 05/12] qlge: Add tx multiqueue support Ron Mercer
2009-03-10 11:46 ` David Miller [this message]
2009-03-09 20:59 ` [net-next PATCH 06/12] qlge: bugfix: Tell hw to strip vlan header Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 07/12] qlge: Get rid of irqsave/restore in intr disable Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 08/12] qlge: Clear shadow registers before use Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 09/12] qlge: Remove spinlock from asic init path Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 10/12] qlge: bugfix: Move netif_napi_del() to common call point Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 11/12] qlge: bugfix: Pad outbound frames smaller than 60 bytes Ron Mercer
2009-03-09 20:59 ` [net-next PATCH 12/12] qlge: bugfix: Fix endian issue related to rx buffers Ron Mercer
-- strict thread matches above, loose matches on Subject: below --
2009-03-10 20:28 [net-next PATCH0/12] qlge: More features and cleanup Ron Mercer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310.044603.190103058.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).