From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gerhard Pircher" Subject: Re: 3c59x: shared interrupt problem Date: Wed, 11 Mar 2009 23:42:40 +0100 Message-ID: <20090311224240.63430@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, shemminger@vyatta.com To: Steffen Klassert Return-path: Received: from mail.gmx.net ([213.165.64.20]:47636 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752129AbZCKWmo (ORCPT ); Wed, 11 Mar 2009 18:42:44 -0400 Sender: netdev-owner@vger.kernel.org List-ID: -------- Original-Nachricht -------- > Datum: Wed, 11 Mar 2009 12:31:30 +0100 > Von: Steffen Klassert > An: Gerhard Pircher > CC: shemminger@vyatta.com, netdev@vger.kernel.org, akpm@linux-foundat= ion.org > Betreff: Re: 3c59x: shared interrupt problem > On Tue, Mar 10, 2009 at 10:00:53AM +0100, Gerhard Pircher wrote: > > >=20 > > > This basically reverts a patch from akpm (bitkeeper cset 1.1046.9= 5.8) > > > This patch was to workaround lots of "nobody cared" warnings=20 > > > generated by boomerang_interrupt(). > > > I added Andrew to the Cc, perhaps he can remember some details on > > > this. > > I'm afraid this patch didn't fix the problem. I'm using scp to copy= a > > big ISO file from my PC to the AmigaOne and the network transfer st= ill > > stalls. > > I made a photo from the kernel oops printed out during shutdown. >=20 > Your photo shows exactly such a "nobody cared" warning that Andrew wa= nted=20 > to get rid of with his patch. >=20 > > BTW: shouldn't the driver use vortex_interrupt() to handle interrup= ts > > for a 3c920? >=20 > It depends on the content of your NIC's eeprom which ISR the driver w= ill > use. > If your NIC is full bus master capable boomerang_interrupt() will be > used, if not vortex_interrupt() will be used. As far as I know the 3c= 920 > is of "tornado" type, so it should be full bus master capable. Okay, I thought there is something wrong, because the 3c920 is listed i= n the "vortex" device table. > Your first report showed dnComplete as a pending interrupt source. > Since the driver uses tx_interrupt_mitigation, this happens just if t= he=20 > tx ring is full. Could you please test the patch below? This disables > tx_interrupt_mitigation, so the dnComplete interrupt will be triggere= d=20 > with every packet. I disabled tx_interrupt_mitigation and tested it with and w/o the patch for boomerang_interrupt(). The network transfer stalls in both cases sooner or later. Here are two photos from the kernel output: - no tx_interrupt_mitigation and patch for booomerang_interrupt(): http://boot.homelinux.org:8080/kernel/oops_boomerang_irq_tx_irq_mitig.j= pg - no tx_interrupt_mitigation only: http://boot.homelinux.org:8080/kernel/oops_tx_irq_mitig.jpg Thanks! best regards, Gerhard --=20 Psssst! Schon vom neuen GMX MultiMessenger geh=F6rt? Der kann`s mit all= en: http://www.gmx.net/de/go/multimessenger01