From: Neil Horman <nhorman@tuxdriver.com>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs
Date: Wed, 11 Mar 2009 20:30:59 -0400 [thread overview]
Message-ID: <20090312003059.GA12554@localhost.localdomain> (raw)
In-Reply-To: <20090311213902.GA18878@ioremap.net>
On Thu, Mar 12, 2009 at 12:39:02AM +0300, Evgeniy Polyakov wrote:
> On Wed, Mar 11, 2009 at 01:07:01PM -0400, Neil Horman (nhorman@tuxdriver.com) wrote:
> > > I was wondering if packets droped at NIC level are handled by "Network Drop Monitor".
> > > (See recent discussion about Multicast packet loss)
> > >
> > > I believe not, maybe I missed something ...
> > >
> > No, unfortunately, theres no really good way to detect drops at the driver level
> > without polling them periodically, which I think is somewhat in opposition to the
> > point of this utility. I'd welcome suggestions however.
>
> It could be possible to check softnet stats difference when napi is
> scheduled or drop monitor is about to send a packet to the userspace
> about different drop.
>
Those are both good ideas. I think I like the former suggestion, since the
latter requires that a drop in the stack must occur to detect a stack closer to
the hardware. Thank you, I'll keep that in mind for a subsequent enhancement.
Regards
Neil
> --
> Evgeniy Polyakov
>
next prev parent reply other threads:[~2009-03-12 0:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 17:03 [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs Neil Horman
2009-03-04 13:54 ` Arnaldo Carvalho de Melo
2009-03-04 14:18 ` Neil Horman
2009-03-04 16:13 ` Arnaldo Carvalho de Melo
2009-03-04 21:06 ` David Miller
2009-03-04 22:45 ` Arnaldo Carvalho de Melo
2009-03-04 22:47 ` David Miller
2009-03-04 22:51 ` Arnaldo Carvalho de Melo
2009-03-04 23:57 ` Patrick McHardy
2009-03-05 21:01 ` Neil Horman
2009-03-11 16:18 ` David Miller
2009-03-11 16:34 ` Eric Dumazet
2009-03-11 16:48 ` David Miller
2009-03-11 17:07 ` Neil Horman
2009-03-11 21:39 ` Evgeniy Polyakov
2009-03-12 0:30 ` Neil Horman [this message]
2009-03-11 19:49 ` Neil Horman
2009-03-13 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312003059.GA12554@localhost.localdomain \
--to=nhorman@tuxdriver.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).