netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Arthur Jones <ajones@riverbed.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	"e1000-devel@lists.sourceforge.net"
	<e1000-devel@lists.sourceforge.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] igb: allow tx of pre-formatted vlan tagged packets
Date: Thu, 12 Mar 2009 14:22:18 -0700	[thread overview]
Message-ID: <20090312142218.5085a043@nehalam> (raw)
In-Reply-To: <20090312210057.GA14957@ajones-laptop.nbttech.com>

On Thu, 12 Mar 2009 14:00:57 -0700
Arthur Jones <ajones@riverbed.com> wrote:

> Hi Stephen, ...
> 
> On Thu, Mar 12, 2009 at 01:51:19PM -0700, Stephen Hemminger wrote:
> > On Thu, 12 Mar 2009 13:27:24 -0700
> > Arthur Jones <ajones@riverbed.com> wrote:
> > 
> > > When the 82575 is fed 802.1q packets, it chokes with
> > > an error of the form:
> > > 
> > > igb 0000:08:00.1: partial checksum but proto=81
> > > 
> > > As the logic there was not smart enough to look into
> > > the vlan header to pick out the encapsulated protocol.
> > > 
> > > There are times when we'd like to send these packets
> > > out without having to configure a vlan on the interface.
> > > Here we check for the vlan tag and allow the packet to
> > > go out with the correct hardware checksum.
> > > 
> > > Thanks to Kand Ly <kand@riverbed.com> for discovering the
> > > issue and the coming up with a solution.  This patch is
> > > based upon his work.
> > > 
> > > Signed-off-by: Arthur Jones <ajones@riverbed.com>
> > > ---
> > >  drivers/net/igb/igb_main.c |   12 +++++++++++-
> > >  1 files changed, 11 insertions(+), 1 deletions(-)
> > 
> > That code in current igb driver (net-next-2.6) tree no longer has
> > the whole switch you are changing.
> 
> Ok, thanks, I'll test that one...
> 
> Arthur

Actually, it is there just a little furthur down than I was looking

  reply	other threads:[~2009-03-12 21:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 20:27 [PATCH] igb: allow tx of pre-formatted vlan tagged packets Arthur Jones
2009-03-12 20:51 ` Stephen Hemminger
2009-03-12 21:00   ` Arthur Jones
2009-03-12 21:22     ` Stephen Hemminger [this message]
2009-03-12 21:33 ` [net-next PATCH] " Arthur Jones
2009-03-12 22:30   ` Alexander Duyck
2009-03-13 14:55     ` Arthur Jones
2009-03-13 16:24       ` Arthur Jones
2009-03-17 17:39   ` [net-next PATCH -- take 2] " Arthur Jones
2009-03-19  6:40     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090312142218.5085a043@nehalam \
    --to=shemminger@vyatta.com \
    --cc=ajones@riverbed.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).