From: Paul Moore <paul.moore@hp.com>
To: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
netdev@vger.kernel.org
Subject: [RFC PATCH v1 0/3] Fix a problem with incoming TCP connections and NetLabel
Date: Thu, 12 Mar 2009 12:22:50 -0400 [thread overview]
Message-ID: <20090312160934.29454.31004.stgit@flek.lan> (raw)
The patches below have more information on the problem but the issue is that
we are not correctly labeling incoming TCP connection sockets at present. Due
to a variety of things all coming together we've gotten a bit lucky in that
the majority of labeled TCP connections are labeled correctly now but this
won't hold for long as some of the new features added recently will break this
"happy coincidence" for some configurations.
For the folks on netdev, you probably only care about the relocation of the
security_inet_conn_request() hooks but this is such a minor move I doubt there
will be much objection. Still, I would appreciate any feedback/comments.
For the folks on the SELinux and LSM lists please take a look and let me know
if the basic approach seems reasonable. Keep in mind I still need to make a
few more passes through the code to clean it up and make sure I haven't done
anything stupid. I've done basic testing under both SELinux and Smack using
2.6.29-rc7 and everything looks okay so far so feel free to play with it but
more testing is still needed.
---
Paul Moore (3):
netlabel: Label incoming TCP connections correctly in Smack
netlabel: Label incoming TCP connections correctly in SELinux
lsm: Relocate the IPv4 security_inet_conn_request() hooks
include/net/cipso_ipv4.h | 17 +++
include/net/netlabel.h | 17 +++
net/ipv4/cipso_ipv4.c | 130 ++++++++++++++++++++++--
net/ipv4/syncookies.c | 9 +-
net/ipv4/tcp_ipv4.c | 7 +
net/netlabel/netlabel_kapi.c | 124 +++++++++++++++++++++--
security/selinux/hooks.c | 54 +++-------
security/selinux/include/netlabel.h | 26 ++---
security/selinux/netlabel.c | 187 ++++++++++-------------------------
security/smack/smack_lsm.c | 53 +++++++---
10 files changed, 393 insertions(+), 231 deletions(-)
next reply other threads:[~2009-03-12 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 16:22 Paul Moore [this message]
2009-03-12 16:22 ` [RFC PATCH v1 1/3] lsm: Relocate the IPv4 security_inet_conn_request() hooks Paul Moore
2009-03-13 18:54 ` David Miller
2009-03-13 19:39 ` Paul Moore
2009-03-12 16:23 ` [RFC PATCH v1 2/3] netlabel: Label incoming TCP connections correctly in SELinux Paul Moore
2009-03-12 16:23 ` [RFC PATCH v1 3/3] netlabel: Label incoming TCP connections correctly in Smack Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312160934.29454.31004.stgit@flek.lan \
--to=paul.moore@hp.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).