From: David Miller <davem@davemloft.net>
To: khali@linux-fr.org
Cc: marcin.slusarz@gmail.com, netdev@vger.kernel.org,
afleming@freescale.com, tpiepho@freescale.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phylib: convert state_queue work to delayed_work
Date: Fri, 13 Mar 2009 15:41:29 -0700 (PDT) [thread overview]
Message-ID: <20090313.154129.08540488.davem@davemloft.net> (raw)
In-Reply-To: <20090307104620.7f2aed57@hyperion.delvare>
From: Jean Delvare <khali@linux-fr.org>
Date: Sat, 7 Mar 2009 10:46:20 +0100
> On Fri, 6 Mar 2009 21:51:42 +0100, Marcin Slusarz wrote:
> > It closes a race in phy_stop_machine when reprogramming of phy_timer
> > (from phy_state_machine) happens between del_timer_sync and cancel_work_sync.
> >
> > Without this change it could lead to crash if phy_device would be freed after
> > phy_stop_machine (timer would fire and schedule freed work).
> >
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > Cc: Andy Fleming <afleming@freescale.com>
> > Cc: Trent Piepho <tpiepho@freescale.com>
> > ---
> >
> > This patch was only compile tested.
>
> Patch looks good.
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
Applied, thanks.
prev parent reply other threads:[~2009-03-13 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 20:51 [PATCH] phylib: convert state_queue work to delayed_work Marcin Slusarz
2009-03-07 9:46 ` Jean Delvare
2009-03-13 22:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313.154129.08540488.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tpiepho@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).