From: David Miller <davem@davemloft.net>
To: klassert@mathematik.tu-chemnitz.de
Cc: akpm@linux-foundation.org, shemminger@vyatta.com,
gerhard_pircher@gmx.net, netdev@vger.kernel.org
Subject: Re: 3c59x: shared interrupt problem
Date: Fri, 13 Mar 2009 15:51:16 -0700 (PDT) [thread overview]
Message-ID: <20090313.155116.183062617.davem@davemloft.net> (raw)
In-Reply-To: <20090311113815.GB26526@newton.mathematik.tu-chemnitz.de>
From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Date: Wed, 11 Mar 2009 12:38:15 +0100
> On Tue, Mar 10, 2009 at 02:55:42PM -0700, Andrew Morton wrote:
> > >
> > > This basically reverts a patch from akpm (bitkeeper cset 1.1046.95.8)
> > > This patch was to workaround lots of "nobody cared" warnings generated by
> > > boomerang_interrupt().
> > > I added Andrew to the Cc, perhaps he can remember some details on this.
> > >
> >
> > Beats me. Do you havea full copy of that patch, including changelog?
> >
>
> It was this one:
>
> #### ChangeSet ####
> 2003-05-19 10:27:49-07:00, akpm@digeo.com
> [PATCH] 3c59x irqreturn fix
>
> Apparently boomerang_interrupt() is generating lots of "nobody cared"
> warnings - one per packet it seems. Frankly, I don't have a clue why.
>
> These are ancient cards and the driver is otherwise stable, so just
> change it to return IRQ_HANDLED and move on...
So basically it's a band-aid because we didn't investigate why
this happens.
I think we should put the change in, and then look into things
properly if users report this issue again.
The code there right now is just completely wrong when the
3c59x interrupt is shared with another device.
next prev parent reply other threads:[~2009-03-13 22:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 22:42 3c59x: shared interrupt problem Gerhard Pircher
2009-03-09 23:49 ` Stephen Hemminger
2009-03-10 8:16 ` Steffen Klassert
2009-03-10 21:55 ` Andrew Morton
2009-03-11 11:38 ` Steffen Klassert
2009-03-13 22:51 ` David Miller [this message]
2009-03-14 14:08 ` Steffen Klassert
2009-03-14 18:40 ` David Miller
2009-03-17 9:37 ` Gerhard Pircher
[not found] ` <20090310090053.322240@gmx.net>
2009-03-11 11:31 ` Steffen Klassert
2009-03-27 7:59 ` Steffen Klassert
2009-03-28 14:17 ` Gerhard Pircher
2009-04-21 18:36 ` Gerhard Pircher
-- strict thread matches above, loose matches on Subject: below --
2009-03-11 22:42 Gerhard Pircher
2009-03-12 14:39 ` Steffen Klassert
2009-03-12 15:12 ` Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313.155116.183062617.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=gerhard_pircher@gmx.net \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).