From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: 3c59x: shared interrupt problem
Date: Fri, 13 Mar 2009 15:51:16 -0700 (PDT)
Message-ID: <20090313.155116.183062617.davem@davemloft.net>
References: <20090310081628.GA3217@newton.mathematik.tu-chemnitz.de>
	<20090310145542.499128ef.akpm@linux-foundation.org>
	<20090311113815.GB26526@newton.mathematik.tu-chemnitz.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: akpm@linux-foundation.org, shemminger@vyatta.com,
	gerhard_pircher@gmx.net, netdev@vger.kernel.org
To: klassert@mathematik.tu-chemnitz.de
Return-path: <netdev-owner@vger.kernel.org>
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:36236
	"EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK)
	by vger.kernel.org with ESMTP id S1751962AbZCMWva (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 13 Mar 2009 18:51:30 -0400
In-Reply-To: <20090311113815.GB26526@newton.mathematik.tu-chemnitz.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Date: Wed, 11 Mar 2009 12:38:15 +0100

> On Tue, Mar 10, 2009 at 02:55:42PM -0700, Andrew Morton wrote:
> > > 
> > > This basically reverts a patch from akpm (bitkeeper cset 1.1046.95.8)
> > > This patch was to workaround lots of "nobody cared" warnings generated by
> > > boomerang_interrupt(). 
> > > I added Andrew to the Cc, perhaps he can remember some details on this.
> > > 
> > 
> > Beats me.  Do you havea full copy of that patch, including changelog?
> > 
> 
> It was this one:
> 
> #### ChangeSet ####
> 2003-05-19 10:27:49-07:00, akpm@digeo.com 
>   [PATCH] 3c59x irqreturn fix
>   
>   Apparently boomerang_interrupt() is generating lots of "nobody cared"
>   warnings - one per packet it seems.  Frankly, I don't have a clue why.
>   
>   These are ancient cards and the driver is otherwise stable, so just
>   change it to return IRQ_HANDLED and move on...

So basically it's a band-aid because we didn't investigate why
this happens.

I think we should put the change in, and then look into things
properly if users report this issue again.

The code there right now is just completely wrong when the
3c59x interrupt is shared with another device.