From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: pktoss@gmail.com, dcbw@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Make virtio_net support carrier detection
Date: Fri, 13 Mar 2009 08:09:49 +1030 [thread overview]
Message-ID: <200903130809.49523.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090312.055235.56926675.davem@davemloft.net>
On Thursday 12 March 2009 23:22:35 David Miller wrote:
> Not adding a link state handler to virtio_net for pompous reasons like
> some theoretical "clean design" claim is idiotic, and in the end bad
> for users who are using existing versions of NetworkManager.
We really don't know if there's a carrier: virtio_net doesn't support it
(yet).
Dan said we can't return "don't know", but he's wrong: you get
-EOPNOTSUPP from ETHTOOL_GLINK. That surely gives userspace the best
possible information.
> If the link is always on, you should make that explicit by providing
> a link state handler, and making sure it always returns true.
"If". We've discussed adding a virtio_net feature to indicate link status,
which implies that it's *not* always on.
Rusty.
next prev parent reply other threads:[~2009-03-12 21:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1236772642-12705-1-git-send-email-pktoss@gmail.com>
2009-03-12 7:29 ` [PATCH] Make virtio_net support carrier detection Rusty Russell
2009-03-12 7:44 ` Pantelis Koukousoulas
2009-03-12 9:16 ` Rusty Russell
2009-03-12 10:23 ` Pantelis Koukousoulas
2009-03-12 11:05 ` Pantelis Koukousoulas
2009-03-12 11:43 ` Dan Williams
2009-03-12 12:47 ` Pantelis Koukousoulas
2009-03-12 12:52 ` David Miller
2009-03-12 12:58 ` Pantelis Koukousoulas
2009-03-12 13:03 ` David Miller
2009-03-12 13:10 ` Pantelis Koukousoulas
2009-03-12 13:41 ` Dan Williams
2009-03-12 13:55 ` Dan Williams
2009-03-12 21:39 ` Rusty Russell [this message]
2009-03-12 23:47 ` Rusty Russell
2009-03-12 23:55 ` Stephen Hemminger
2009-03-13 5:04 ` Pantelis Koukousoulas
2009-03-13 19:01 ` David Miller
2009-03-14 0:19 ` Rusty Russell
2009-03-14 10:40 ` Pantelis Koukousoulas
2009-03-14 11:33 ` Pantelis Koukousoulas
2009-03-15 22:39 ` Rusty Russell
2009-03-16 2:05 ` Pantelis Koukousoulas
2009-03-16 2:58 ` David Miller
2009-03-16 3:13 ` Rusty Russell
2009-03-16 3:15 ` David Miller
2009-03-14 0:23 Rusty Russell
2009-03-19 1:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903130809.49523.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pktoss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).