From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: netdev@vger.kernel.org, stable@kernel.org
Subject: [PATCH] Make virtio_net support carrier detection
Date: Sat, 14 Mar 2009 10:53:51 +1030 [thread overview]
Message-ID: <200903141053.51819.rusty@rustcorp.com.au> (raw)
Impact: Make NetworkManager work with virtio_net
For now the semantics are simple: There is always carrier.
This allows a seamless experience with e.g., qemu/kvm
where NetworkManager just configures and sets up
everything automagically.
If/when a generally agreed-upon way to control
carrier on/off in the emulator/hypervisor level
emerges, it will be trivial to extend the driver
to support that too, but for now even this 2-liner
makes user experience that much better.
Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
Acked-by: David Miller <davem@davemloft.net>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/net/virtio_net.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index c688083..e67d16c 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -612,6 +612,7 @@ static struct ethtool_ops virtnet_ethtool_ops = {
.set_tx_csum = virtnet_set_tx_csum,
.set_sg = ethtool_op_set_sg,
.set_tso = ethtool_op_set_tso,
+ .get_link = ethtool_op_get_link,
};
#define MIN_MTU 68
@@ -739,6 +740,8 @@ static int virtnet_probe(struct virtio_device *vdev)
goto unregister;
}
+ netif_carrier_on(dev);
+
pr_debug("virtnet: registered device %s\n", dev->name);
return 0;
--
1.5.6.3
next reply other threads:[~2009-03-14 0:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 0:23 Rusty Russell [this message]
2009-03-19 1:40 ` [PATCH] Make virtio_net support carrier detection David Miller
[not found] <1236772642-12705-1-git-send-email-pktoss@gmail.com>
2009-03-12 7:29 ` Rusty Russell
2009-03-12 7:44 ` Pantelis Koukousoulas
2009-03-12 9:16 ` Rusty Russell
2009-03-12 10:23 ` Pantelis Koukousoulas
2009-03-12 11:05 ` Pantelis Koukousoulas
2009-03-12 11:43 ` Dan Williams
2009-03-12 12:47 ` Pantelis Koukousoulas
2009-03-12 12:52 ` David Miller
2009-03-12 12:58 ` Pantelis Koukousoulas
2009-03-12 13:03 ` David Miller
2009-03-12 13:10 ` Pantelis Koukousoulas
2009-03-12 13:41 ` Dan Williams
2009-03-12 13:55 ` Dan Williams
2009-03-12 21:39 ` Rusty Russell
2009-03-12 23:47 ` Rusty Russell
2009-03-12 23:55 ` Stephen Hemminger
2009-03-13 5:04 ` Pantelis Koukousoulas
2009-03-13 19:01 ` David Miller
2009-03-14 0:19 ` Rusty Russell
2009-03-14 10:40 ` Pantelis Koukousoulas
2009-03-14 11:33 ` Pantelis Koukousoulas
2009-03-15 22:39 ` Rusty Russell
2009-03-16 2:05 ` Pantelis Koukousoulas
2009-03-16 2:58 ` David Miller
2009-03-16 3:13 ` Rusty Russell
2009-03-16 3:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903141053.51819.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).