From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] r8169: revert "r8169: read MAC address from EEPROM on init (2nd attempt)" Date: Sun, 15 Mar 2009 20:04:57 -0700 (PDT) Message-ID: <20090315.200457.14869148.davem@davemloft.net> References: <20090315111050.GB17800@electric-eye.fr.zoreil.com> <18877.41709.567947.25614@pilspetsen.it.uu.se> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: romieu@fr.zoreil.com, davej@redhat.com, tdurack@gmail.com, ivecera@redhat.com, netdev@vger.kernel.org To: mikpe@it.uu.se Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59637 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752204AbZCPDFK (ORCPT ); Sun, 15 Mar 2009 23:05:10 -0400 In-Reply-To: <18877.41709.567947.25614@pilspetsen.it.uu.se> Sender: netdev-owner@vger.kernel.org List-ID: From: Mikael Pettersson Date: Mon, 16 Mar 2009 01:53:01 +0100 > Francois Romieu writes: > > It fails on the following systems: > > - RTL8169sc/8110sc (XID 18000000) > > reported by Tim Durack (x86) > > - RTL8169sb/8110sb (XID 10000000) > > reported by Mikael Pettersson (ARM) > > > > The patch appeared to work on x86 for the following systems: > > RTL8169sb/8110sb 10000000 PCI (EXT) > > RTL8110s 04000000 PCI (EXT) > > RTL8102e 24a00000 PCI-E (LOM) > > RTL8168c/8111c 3c2000c0 PCI-E (LOM) > > RTL8168b/8111b 38000000 PCI-E (LOM) > > RTL8168b/8111b 38000000 PCI-E (EXT) > > > > The patch exposes two problems: > > 1) while not completely wrong, mac addresses are not read correctly > > from the EEPROM > > 2) the MAC address registers are not correctly set > > > > Signed-off-by: Francois Romieu > > Thanks. With these two patches applied 2.6.29-rc8 now works fine > with the r8169 in my NAS box. > > Tested-by: Mikael Pettersson Also applied, thanks everyone.