From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org, zbr@ioremap.net, mingo@elte.hu
Subject: Re: [PATCH 5/7] tcp: simplify tcp_current_mss
Date: Sun, 15 Mar 2009 20:10:53 -0700 (PDT) [thread overview]
Message-ID: <20090315.201053.220050794.davem@davemloft.net> (raw)
In-Reply-To: <12370756751028-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sun, 15 Mar 2009 02:07:53 +0200
> There's very little need for most of the callsites to get
> tp->xmit_goal_size updated. That will cost us divide as is,
> so slice the function in two. Also, the only users of the
> tp->xmit_goal_size are directly behind tcp_current_mss(),
> so there's no need to store that variable into tcp_sock
> at all! The drop of xmit_goal_size currently leaves 16-bit
> hole and some reorganization would again be necessary to
> change that (but I'm aiming to fill that hole with u16
> xmit_goal_size_segs to cache the results of the remaining
> divide to get that tso on regression).
>
> Bring xmit_goal_size parts into tcp.c
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied.
next prev parent reply other threads:[~2009-03-16 3:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1237075675426-git-send-email-ilpo.jarvinen@helsinki.fi>
2009-03-16 3:10 ` [PATCH 1/7] tcp: remove pointless .dsack/.num_sacks code David Miller
[not found] ` <12370756753599-git-send-email-ilpo.jarvinen@helsinki.fi>
2009-03-16 3:10 ` [PATCH 2/7] tcp: kill dead end_seq variable in clean_rtx_queue David Miller
[not found] ` <12370756754094-git-send-email-ilpo.jarvinen@helsinki.fi>
2009-03-16 3:10 ` [PATCH 3/7] tcp: consolidate paws check David Miller
[not found] ` <12370756752410-git-send-email-ilpo.jarvinen@helsinki.fi>
2009-03-16 3:10 ` [PATCH 4/7] tcp: don't check mtu probe completion in the loop David Miller
[not found] ` <12370756751028-git-send-email-ilpo.jarvinen@helsinki.fi>
[not found] ` <12370756752721-git-send-email-ilpo.jarvinen@helsinki.fi>
2009-03-15 8:36 ` [PATCH 6/7] tcp: cache result of earlier divides when mss-aligning things Evgeniy Polyakov
2009-03-15 8:45 ` Ilpo Järvinen
2009-03-15 9:08 ` Evgeniy Polyakov
2009-03-16 3:11 ` David Miller
[not found] ` <12370756754020-git-send-email-ilpo.jarvinen@helsinki.fi>
2009-03-16 3:11 ` [PATCH 7/7] tcp: make sure xmit goal size never becomes zero David Miller
2009-03-16 3:10 ` David Miller [this message]
2009-03-15 0:23 [PATCH 1/7] tcp: remove pointless .dsack/.num_sacks code Ilpo Järvinen
2009-03-15 0:23 ` [PATCH 2/7] tcp: kill dead end_seq variable in clean_rtx_queue Ilpo Järvinen
2009-03-15 0:23 ` [PATCH 3/7] tcp: consolidate paws check Ilpo Järvinen
2009-03-15 0:23 ` [PATCH 4/7] tcp: don't check mtu probe completion in the loop Ilpo Järvinen
2009-03-15 0:23 ` [PATCH 5/7] tcp: simplify tcp_current_mss Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315.201053.220050794.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).