From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: jarkao2@gmail.com, emil.s.tantilov@intel.com,
alexander.h.duyck@intel.com, jesse.brandeburg@intel.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org
Subject: Re: Kernel panic during stress with igb in the upstream kernel
Date: Tue, 17 Mar 2009 13:11:05 -0700 (PDT) [thread overview]
Message-ID: <20090317.131105.111221133.davem@davemloft.net> (raw)
In-Reply-To: <20090317100203.GA23396@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 17 Mar 2009 18:02:03 +0800
> On Tue, Mar 17, 2009 at 09:37:24AM +0000, Jarek Poplawski wrote:
> >
> > Probably I miss something, but you seem to assume here this skb will
> > be taken by netpoll later. But if it's not active (trapped) vlan
> > packet will be passed as "normal"?
>
> Good point. I'll see if this stuff can be simplified further,
> but for now, let's go for the obvious fix.
>
> gro: Fix vlan/netpoll check again
>
> Jarek Poplawski pointed out that my previous fix is broken for
> VLAN+netpoll as if netpoll is enabled we'd end up in the normal
> receive path instead of the VLAN receive path.
>
> This patch fixes it by calling the VLAN receive hook.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
prev parent reply other threads:[~2009-03-17 20:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EA929A9653AAE14F841771FB1DE5A1365F69CA4280@rrsmsx501.amr.corp.intel.com>
2009-03-13 11:52 ` FW: Kernel panic during stress with igb in the upstream kernel Herbert Xu
2009-03-13 21:53 ` Tantilov, Emil S
2009-03-13 21:54 ` David Miller
2009-03-13 23:59 ` Herbert Xu
2009-03-16 3:13 ` David Miller
2009-03-16 3:18 ` David Miller
2009-03-16 13:22 ` Herbert Xu
2009-03-16 17:50 ` David Miller
2009-03-17 9:37 ` Jarek Poplawski
2009-03-17 10:02 ` Herbert Xu
2009-03-17 20:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317.131105.111221133.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=emil.s.tantilov@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).