netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: weiyi.huang@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: dnet: remove duplicated #include
Date: Wed, 18 Mar 2009 14:32:18 -0700 (PDT)	[thread overview]
Message-ID: <20090318.143218.249024701.davem@davemloft.net> (raw)
In-Reply-To: <49C0E751.4010902@gmail.com>

From: Huang Weiyi <weiyi.huang@gmail.com>
Date: Wed, 18 Mar 2009 20:21:37 +0800

> Removed duplicated #include in drivers/net/dnet.c.
> 
> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
> 
> diff --git a/drivers/net/dnet.c b/drivers/net/dnet.c
> index 5c347f7..8a98d40 100644
> --- a/drivers/net/dnet.c
> +++ b/drivers/net/dnet.c
> @@ -21,7 +21,6 @@
>   #include <linux/dma-mapping.h>
>   #include <linux/platform_device.h>
>   #include <linux/phy.h>
> -#include <linux/platform_device.h>
> 

This patch has been corrupted by your email client, there should
be one space before each unmodified line in the patch but
there are instead two here.

Really, for a simple one-line change like this, all of the work
of integrating the change are the important issues like this,
so please fix this up and try to get it right in the future.

      reply	other threads:[~2009-03-18 21:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 12:21 dnet: remove duplicated #include Huang Weiyi
2009-03-18 21:32 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090318.143218.249024701.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=weiyi.huang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).