From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: jorge@dti2.net, netdev@vger.kernel.org
Subject: Re: [PATCHv3] netns: oops in ip[6]_frag_reasm incrementing stats
Date: Thu, 19 Mar 2009 23:09:27 +0100 [thread overview]
Message-ID: <20090319220927.GB2714@ami.dom.local> (raw)
In-Reply-To: <20090319.145649.51207208.davem@davemloft.net>
On Thu, Mar 19, 2009 at 02:56:49PM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Thu, 19 Mar 2009 22:54:28 +0100
>
> > On Wed, Mar 18, 2009 at 11:26:51PM -0700, David Miller wrote:
> > > Netfilter on ipv6 handles reassembly differently and in a way
> > > that won't result in dev being NULL here.
> > >
> > > I've applied Jorge's patch, thanks everyone.
> >
> > My proposal is to revert the ipv6/reassembly part of this patch yet;
> > it doesn't fix anything, and the changelog is only misleading if it's
> > like you said.
>
> I've already pushed the change out to net-2.6 so I'd really prefer not
> to do that. Make your desires known more emphatically before a patch
> has been sitting around for days.
I guess you should re-read the thread: if not me, the author of this
patch was very emphatical...
>
> At worst it's a consistency cleanup with an inaccurate commit message,
> reverting will only make the situation more confusing and ugly.
Sure, no big deal.
Jarek P.
next prev parent reply other threads:[~2009-03-19 22:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 16:21 [PATCH] netns: oops in ip_frag_reasm incrementing stats Jorge Boncompte [DTI2]
2009-03-13 16:35 ` [PATCHv2] " Jorge Boncompte [DTI2]
2009-03-16 12:09 ` Jorge Boncompte [DTI2]
2009-03-16 21:05 ` Jarek Poplawski
2009-03-16 21:53 ` Jorge Boncompte [DTI2]
2009-03-16 22:05 ` Jarek Poplawski
2009-03-16 22:46 ` Jarek Poplawski
2009-03-17 11:55 ` [PATCHv3] netns: oops in ip[6]_frag_reasm " Jorge Boncompte [DTI2]
2009-03-17 13:21 ` Jarek Poplawski
2009-03-17 13:54 ` Jorge Boncompte [DTI2]
2009-03-18 7:26 ` Jarek Poplawski
2009-03-19 6:26 ` David Miller
2009-03-19 21:54 ` Jarek Poplawski
2009-03-19 21:56 ` David Miller
2009-03-19 22:09 ` Jarek Poplawski [this message]
2009-03-13 18:46 ` [PATCH] netns: oops in ip_frag_reasm " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319220927.GB2714@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=jorge@dti2.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).