* [PATCH] sungem: missing net_device_ops
@ 2009-03-20 6:53 Stephen Hemminger
2009-03-20 6:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2009-03-20 6:53 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Sungem driver only got partially converted to net_device_ops.
Since this could cause bugs, please push this to 2.6.29
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sungem.c 2009-03-19 23:42:39.988903014 -0700
+++ b/drivers/net/sungem.c 2009-03-19 23:43:47.282840042 -0700
@@ -2998,8 +2998,11 @@ static const struct net_device_ops gem_n
.ndo_do_ioctl = gem_ioctl,
.ndo_tx_timeout = gem_tx_timeout,
.ndo_change_mtu = gem_change_mtu,
- .ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
+ .ndo_set_mac_address = gem_set_mac_address,
+#ifdef CONFIG_NET_POLL_CONTROLLER
+ .ndo_poll_controller = gem_poll_controller,
+#endif
};
static int __devinit gem_init_one(struct pci_dev *pdev,
@@ -3161,10 +3164,6 @@ static int __devinit gem_init_one(struct
dev->watchdog_timeo = 5 * HZ;
dev->irq = pdev->irq;
dev->dma = 0;
- dev->set_mac_address = gem_set_mac_address;
-#ifdef CONFIG_NET_POLL_CONTROLLER
- dev->poll_controller = gem_poll_controller;
-#endif
/* Set that now, in case PM kicks in now */
pci_set_drvdata(pdev, dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sungem: missing net_device_ops
2009-03-20 6:53 [PATCH] sungem: missing net_device_ops Stephen Hemminger
@ 2009-03-20 6:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-03-20 6:58 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 19 Mar 2009 23:53:13 -0700
> Sungem driver only got partially converted to net_device_ops.
> Since this could cause bugs, please push this to 2.6.29
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-20 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-20 6:53 [PATCH] sungem: missing net_device_ops Stephen Hemminger
2009-03-20 6:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).