From: David Miller <davem@davemloft.net>
To: yanghy@cn.fujitsu.com
Cc: shemminger@vyatta.com, chas@cmf.nrl.navy.mil, netdev@vger.kernel.org
Subject: Re: [PATCH] atm: lec use dev_change_mtu
Date: Fri, 20 Mar 2009 00:48:41 -0700 (PDT) [thread overview]
Message-ID: <20090320.004841.194259369.davem@davemloft.net> (raw)
In-Reply-To: <49C34990.1020500@cn.fujitsu.com>
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Date: Fri, 20 Mar 2009 15:45:20 +0800
> Stephen Hemminger wrote:
> > Rather than calling device pointer directly (which is incorrect with
> > net_device_ops), use the standard dev_change_mtu. Compile tested only.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> > --- a/net/atm/lec.c 2009-03-19 17:18:35.140652628 -0700
> > +++ b/net/atm/lec.c 2009-03-19 17:19:19.500777355 -0700
> > @@ -502,7 +502,7 @@ static int lec_atm_send(struct atm_vcc *
> > priv->lane2_ops = NULL;
> > if (priv->lane_version > 1)
> > priv->lane2_ops = &lane2_ops;
> > - if (dev->change_mtu(dev, mesg->content.config.mtu))
> > + if (dev_set_mtu(dev, mesg->content.config.mtu))
>
> I think it's not correct.This dev->change_mtu is:
> 663 static int lec_change_mtu(struct net_device *dev, int new_mtu)
> 664 {
> 665 if ((new_mtu < 68) || (new_mtu > 18190))
> 666 return -EINVAL;
> 667 dev->mtu = new_mtu;
> ^^^^^^^^^^^^^^^^maybe should use dev_set_mtu() here.
> 668 return 0;
> 669 }
>
> and it's not quite same as dev_set_mtu.
dev_set_mtu() calls netdev->ops->ndo_set_mtu() so it will call
this function you are quoting.
next prev parent reply other threads:[~2009-03-20 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 0:24 [PATCH] atm: lec use dev_change_mtu Stephen Hemminger
2009-03-20 7:26 ` Yang Hongyang
2009-03-20 7:45 ` Yang Hongyang
2009-03-20 7:48 ` David Miller [this message]
2009-03-20 7:59 ` Yang Hongyang
2009-03-21 20:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320.004841.194259369.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).