From: David Miller <davem@davemloft.net>
To: yanghy@cn.fujitsu.com
Cc: jens@de.ibm.com, kou.ishizaki@toshiba.co.jp, netdev@vger.kernel.org
Subject: Re: [PATCH]spider_net:remove '&' in the init of function pointers
Date: Fri, 20 Mar 2009 01:21:52 -0700 (PDT) [thread overview]
Message-ID: <20090320.012152.95177338.davem@davemloft.net> (raw)
In-Reply-To: <49C3515D.7090703@cn.fujitsu.com>
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Date: Fri, 20 Mar 2009 16:18:37 +0800
> Do not need '&' in the init of function pointers.
>
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
It's harmless, just leave it alone. This is just going to be commit
noise.
More useful would be to convert this driver over to net_device_ops.
I'm not applying this.
next prev parent reply other threads:[~2009-03-20 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 8:18 [PATCH]spider_net:remove '&' in the init of function pointers Yang Hongyang
2009-03-20 8:21 ` David Miller [this message]
2009-03-20 8:24 ` Yang Hongyang
2009-03-20 8:32 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320.012152.95177338.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jens@de.ibm.com \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=netdev@vger.kernel.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).