From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 2/2] ipx: use constant for strings and desciptor
Date: Fri, 20 Mar 2009 08:44:27 -0700 [thread overview]
Message-ID: <20090320084427.5b09049d@nehalam> (raw)
In-Reply-To: <20090320084314.5761b1d9@nehalam>
Fix compiler warning about non-const format string.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/ipx/af_ipx.c 2009-03-19 23:37:56.671964109 -0700
+++ b/net/ipx/af_ipx.c 2009-03-19 23:46:55.613777665 -0700
@@ -1975,15 +1975,15 @@ static struct notifier_block ipx_dev_not
extern struct datalink_proto *make_EII_client(void);
extern void destroy_EII_client(struct datalink_proto *);
-static unsigned char ipx_8022_type = 0xE0;
-static unsigned char ipx_snap_id[5] = { 0x0, 0x0, 0x0, 0x81, 0x37 };
-static char ipx_EII_err_msg[] __initdata =
+static const unsigned char ipx_8022_type = 0xE0;
+static const unsigned char ipx_snap_id[5] = { 0x0, 0x0, 0x0, 0x81, 0x37 };
+static const char ipx_EII_err_msg[] __initconst =
KERN_CRIT "IPX: Unable to register with Ethernet II\n";
-static char ipx_8023_err_msg[] __initdata =
+static const char ipx_8023_err_msg[] __initconst =
KERN_CRIT "IPX: Unable to register with 802.3\n";
-static char ipx_llc_err_msg[] __initdata =
+static const char ipx_llc_err_msg[] __initconst =
KERN_CRIT "IPX: Unable to register with 802.2\n";
-static char ipx_snap_err_msg[] __initdata =
+static const char ipx_snap_err_msg[] __initconst =
KERN_CRIT "IPX: Unable to register with SNAP\n";
static int __init ipx_init(void)
next prev parent reply other threads:[~2009-03-20 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 15:43 [PATCH 1/2] snap: use const for descirptor Stephen Hemminger
2009-03-20 15:44 ` Stephen Hemminger [this message]
2009-03-20 15:45 ` [PATCH 2/2] ipx: use constant for strings and desciptor Stephen Hemminger
2009-03-20 18:17 ` Arnaldo Carvalho de Melo
2009-03-22 2:08 ` David Miller
2009-03-20 18:16 ` [PATCH 1/2] snap: use const for descirptor Arnaldo Carvalho de Melo
2009-03-22 2:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320084427.5b09049d@nehalam \
--to=shemminger@linux-foundation.org \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).