netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ingo Molnar <mingo@elte.hu>, Yinghai Lu <yinghai@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <matthew@wil.cx>,
	Jesse Brandeburg <jesse.brandeburg@gmail.com>,
	David Miller <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	NetDev <netdev@vger.kernel.org>,
	linux-pci@vger.kernel.org,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] pci: fix kexec with power state D3
Date: Fri, 20 Mar 2009 12:29:16 +0100	[thread overview]
Message-ID: <200903201229.18962.rjw@sisk.pl> (raw)
In-Reply-To: <20090319184948.44bf5e9a@hobbes.lan>

On Friday 20 March 2009, Jesse Barnes wrote:
> > > And, quite frankly, I'm not sure if users will be happy with 
> > > the $subject patch, because it _really_ breaks things (well, 
> > > the kexec users who don't use suspend might be, but surely 
> > > suspend users who don't use kexec won't).
> > 
> > Please note that i havent reviewed the patches and i did not 
> > take any sides in the discussion - i just flagged the maintainer 
> > ping-pong. As long as we pick one of the patches (or a third 
> > one) within a bound amount of time we should be fine :)
> 
> I'll defer to Rafael here; he's been working the most in this area.
> The changelog wasn't very complete for the original patch, but it
> sounds like in the kexec case the newly booted kernel will get an igb
> device in D3 which it can't handle?  That really does sound like a
> driver bug, not something we should mess with in the core.

I have already posted an alternative patch for igb that's been reported to
fix the problem.

Thanks,
Rafael

      reply	other threads:[~2009-03-20 11:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-07  4:33 [PATCH] igb: fix kexec with igb Yinghai Lu
2009-03-07  7:18 ` Jesse Brandeburg
2009-03-07  7:31   ` Yinghai Lu
2009-03-07 18:20     ` Eric W. Biederman
2009-03-07 18:50       ` Yinghai Lu
2009-03-08 10:45         ` Rafael J. Wysocki
2009-03-08 10:57     ` Rafael J. Wysocki
2009-03-08 18:03       ` Yinghai Lu
2009-03-08 18:10       ` Yinghai Lu
2009-03-08 21:08         ` Rafael J. Wysocki
2009-03-08 21:18           ` Yinghai Lu
2009-03-08 21:40             ` Rafael J. Wysocki
2009-03-08 21:32           ` Rafael J. Wysocki
2009-03-08 22:35             ` Yinghai Lu
2009-03-08 22:57               ` Rafael J. Wysocki
2009-03-08 23:04                 ` Yinghai Lu
2009-03-08 23:57                   ` Rafael J. Wysocki
2009-03-11 23:37             ` Yinghai Lu
2009-03-21 22:04               ` [Updated patch] " Rafael J. Wysocki
2009-03-24 22:35                 ` Yinghai Lu
2009-03-28 21:27                   ` Rafael J. Wysocki
2009-03-29  2:30                     ` Jeff Kirsher
2009-03-29 11:19                       ` Rafael J. Wysocki
2009-03-30 21:36                         ` Jeff Kirsher
2009-03-30 21:39                           ` Rafael J. Wysocki
2009-03-31 19:14                             ` Tantilov, Emil S
2009-03-31 19:51                               ` Jeff Kirsher
2009-03-31 20:27                                 ` Rafael J. Wysocki
2009-03-08  8:09   ` [PATCH] pci: fix kexec with power state D3 Yinghai Lu
2009-03-08 10:08     ` Rafael J. Wysocki
2009-03-08 10:15       ` Ingo Molnar
2009-03-08 10:28         ` Rafael J. Wysocki
2009-03-08 10:33           ` Rafael J. Wysocki
2009-03-08 11:08             ` Ingo Molnar
2009-03-20  1:49               ` Jesse Barnes
2009-03-20 11:29                 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903201229.18962.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jesse.brandeburg@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).