From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 33/77] usbnet: convert rndis driver to net_device_ops Date: Sat, 21 Mar 2009 02:23:09 -0700 Message-ID: <200903210223.09674.david-b@pacbell.net> References: <20090321053527.316395697@vyatta.com> <20090321053715.035583259@vyatta.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from smtp127.sbc.mail.sp1.yahoo.com ([69.147.65.186]:46452 "HELO smtp127.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753378AbZCUJZ7 (ORCPT ); Sat, 21 Mar 2009 05:25:59 -0400 In-Reply-To: <20090321053715.035583259@vyatta.com> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Friday 20 March 2009, Stephen Hemminger wrote: > Signed-off-by: Stephen Hemminger Acked-by: David Brownell > --- a/drivers/net/usb/rndis_host.c 2009-03-20 12:18:22.041027638 -0700 > +++ b/drivers/net/usb/rndis_host.c 2009-03-20 12:27:20.541841282 -0700 > @@ -266,6 +266,16 @@ response_error: > return -EDOM; > } > > +/* same as usbnet_netdev_ops but MTU change not allowed */ > +static const struct net_device_ops rndis_netdev_ops = { > + .ndo_open = usbnet_open, > + .ndo_stop = usbnet_stop, > + .ndo_start_xmit = usbnet_start_xmit, > + .ndo_tx_timeout = usbnet_tx_timeout, > + .ndo_set_mac_address = eth_mac_addr, > + .ndo_validate_addr = eth_validate_addr, > +}; > + > int > generic_rndis_bind(struct usbnet *dev, struct usb_interface *intf, int flags) > { > @@ -327,7 +337,8 @@ generic_rndis_bind(struct usbnet *dev, s > dev->rx_urb_size &= ~(dev->maxpacket - 1); > u.init->max_transfer_size = cpu_to_le32(dev->rx_urb_size); > > - net->change_mtu = NULL; > + net->netdev_ops = &rndis_netdev_ops; > + > retval = rndis_command(dev, u.header, CONTROL_BUFFER_SIZE); > if (unlikely(retval < 0)) { > /* it might not even be an RNDIS device!! */ > > -- > >