netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	mcgrof-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 68/77] prism54: convert to internal net_device_stats
Date: Fri, 20 Mar 2009 22:36:35 -0700	[thread overview]
Message-ID: <20090321053717.765575826@vyatta.com> (raw)
In-Reply-To: 20090321053527.316395697@vyatta.com

[-- Attachment #1: lscpi-stats.patch --]
[-- Type: text/plain, Size: 3881 bytes --]

Also, make ethtool_ops const as it should be, and get rid
of useless cast.

Signed-off-by: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>

---
 drivers/net/wireless/prism54/islpci_dev.c |   14 --------------
 drivers/net/wireless/prism54/islpci_dev.h |    3 ---
 drivers/net/wireless/prism54/islpci_eth.c |   13 ++++++-------
 3 files changed, 6 insertions(+), 24 deletions(-)

--- a/drivers/net/wireless/prism54/islpci_dev.c	2009-03-20 18:37:36.129838594 -0700
+++ b/drivers/net/wireless/prism54/islpci_dev.c	2009-03-20 18:37:36.137839156 -0700
@@ -43,7 +43,6 @@
 
 static int prism54_bring_down(islpci_private *);
 static int islpci_alloc_memory(islpci_private *);
-static struct net_device_stats *islpci_statistics(struct net_device *);
 
 /* Temporary dummy MAC address to use until firmware is loaded.
  * The idea there is that some tools (such as nameif) may query
@@ -614,18 +613,6 @@ islpci_reset(islpci_private *priv, int r
 	return rc;
 }
 
-static struct net_device_stats *
-islpci_statistics(struct net_device *ndev)
-{
-	islpci_private *priv = netdev_priv(ndev);
-
-#if VERBOSE > SHOW_ERROR_MESSAGES
-	DEBUG(SHOW_FUNCTION_CALLS, "islpci_statistics\n");
-#endif
-
-	return &priv->statistics;
-}
-
 /******************************************************************************
     Network device configuration functions
 ******************************************************************************/
@@ -811,7 +798,6 @@ static const struct ethtool_ops islpci_e
 static const struct net_device_ops islpci_netdev_ops = {
 	.ndo_open 		= islpci_open,
 	.ndo_stop		= islpci_close,
-	.ndo_get_stats		= islpci_statistics,
 	.ndo_do_ioctl		= prism54_ioctl,
 	.ndo_start_xmit		= islpci_eth_transmit,
 	.ndo_tx_timeout		= islpci_eth_tx_timeout,
--- a/drivers/net/wireless/prism54/islpci_dev.h	2009-03-20 18:36:43.697901654 -0700
+++ b/drivers/net/wireless/prism54/islpci_dev.h	2009-03-20 18:37:36.137839156 -0700
@@ -158,9 +158,6 @@ typedef struct {
 	dma_addr_t pci_map_tx_address[ISL38XX_CB_TX_QSIZE];
 	dma_addr_t pci_map_rx_address[ISL38XX_CB_RX_QSIZE];
 
-	/* driver network interface members */
-	struct net_device_stats statistics;
-
 	/* wait for a reset interrupt */
 	wait_queue_head_t reset_done;
 
--- a/drivers/net/wireless/prism54/islpci_eth.c	2009-03-20 18:37:59.821964445 -0700
+++ b/drivers/net/wireless/prism54/islpci_eth.c	2009-03-20 18:38:59.740714710 -0700
@@ -231,8 +231,8 @@ islpci_eth_transmit(struct sk_buff *skb,
 
 	/* set the transmission time */
 	ndev->trans_start = jiffies;
-	priv->statistics.tx_packets++;
-	priv->statistics.tx_bytes += skb->len;
+	ndev->stats.tx_packets++;
+	ndev->stats.tx_bytes += skb->len;
 
 	/* trigger the device */
 	islpci_trigger(priv);
@@ -243,7 +243,7 @@ islpci_eth_transmit(struct sk_buff *skb,
 	return 0;
 
       drop_free:
-	priv->statistics.tx_dropped++;
+	ndev->stats.tx_dropped++;
 	spin_unlock_irqrestore(&priv->slock, flags);
 	dev_kfree_skb(skb);
 	return err;
@@ -408,8 +408,8 @@ islpci_eth_receive(islpci_private *priv)
 		skb->protocol = eth_type_trans(skb, ndev);
 	}
 	skb->ip_summed = CHECKSUM_NONE;
-	priv->statistics.rx_packets++;
-	priv->statistics.rx_bytes += size;
+	ndev->stats.rx_packets++;
+	ndev->stats.rx_bytes += size;
 
 	/* deliver the skb to the network layer */
 #ifdef ISLPCI_ETH_DEBUG
@@ -497,10 +497,9 @@ void
 islpci_eth_tx_timeout(struct net_device *ndev)
 {
 	islpci_private *priv = netdev_priv(ndev);
-	struct net_device_stats *statistics = &priv->statistics;
 
 	/* increment the transmit error counter */
-	statistics->tx_errors++;
+	ndev->stats.tx_errors++;
 
 	if (!priv->reset_task_pending) {
 		printk(KERN_WARNING

-- 

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-03-21  5:36 UTC|newest]

Thread overview: 197+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-21  5:35 [PATCH 00/77] Convert most of the rest of the devices to net_device_ops Stephen Hemminger
2009-03-21  5:35 ` [PATCH 01/77] atm: convert mpc device to using netdev_ops Stephen Hemminger
2009-03-21 11:44   ` Chas Williams (CONTRACTOR)
2009-03-22  2:34   ` David Miller
2009-03-21  5:35 ` [PATCH 02/77] atm: cconvert clip driver to net_device_ops Stephen Hemminger
2009-03-22  2:34   ` David Miller
2009-03-21  5:35 ` [ofa-general] [PATCH 03/77] infiniband: convert c2 " Stephen Hemminger
2009-03-21 18:26   ` [ofa-general] " Steve Wise
2009-03-22  2:34   ` David Miller
2009-03-22 16:12   ` [ofa-general] " Roland Dreier
2009-03-23  4:17     ` David Miller
2009-03-21  5:35 ` [ofa-general] [PATCH 04/77] infiniband: convert nes driver " Stephen Hemminger
2009-03-22  2:34   ` David Miller
2009-03-21  5:35 ` [ofa-general] [PATCH 05/77] infiniband: convert ipoib " Stephen Hemminger
2009-03-22  2:34   ` [ofa-general] " David Miller
2009-03-21  5:35 ` [PATCH 06/77] irda: net_device_ops ioctl fix Stephen Hemminger
2009-03-22  2:34   ` David Miller
2009-03-23 11:33   ` Samuel Ortiz
2009-03-23 11:33   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 07/77] irlan: convert to net_device_ops Stephen Hemminger
2009-03-22  2:34   ` David Miller
2009-03-23 11:33   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 08/77] irda: convert irda_usb " Stephen Hemminger
2009-03-22  2:34   ` David Miller
2009-03-23 11:34   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 09/77] irda: convert mcs driver " Stephen Hemminger
2009-03-22  2:34   ` David Miller
2009-03-23 11:34   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 10/77] stir4200: convert " Stephen Hemminger
2009-03-22  2:34   ` David Miller
2009-03-23 11:34   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 11/77] irda: convert w83977af_ir " Stephen Hemminger
2009-03-22  2:36   ` David Miller
2009-03-23 11:35   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 12/77] irda: convert nsc_ircc driver " Stephen Hemminger
2009-03-22  2:36   ` David Miller
2009-03-23 11:35   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 13/77] irda: convert ali " Stephen Hemminger
2009-03-22  2:36   ` David Miller
2009-03-23 11:35   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 14/77] irda: convert vlsi " Stephen Hemminger
2009-03-22  2:36   ` David Miller
2009-03-23 11:35   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 15/77] irda: convert smsc " Stephen Hemminger
2009-03-22  2:36   ` David Miller
2009-03-23 11:36   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 16/77] irda: convert via-ircc " Stephen Hemminger
2009-03-22  2:36   ` David Miller
2009-03-23 11:36   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 17/77] irda: convert sir device " Stephen Hemminger
2009-03-22  2:36   ` David Miller
2009-03-23 11:36   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 18/77] irda: convert kignsun " Stephen Hemminger
2009-03-22  2:37   ` David Miller
2009-03-23 11:37   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 19/77] irda: convert ksdazzle " Stephen Hemminger
2009-03-22  2:37   ` David Miller
2009-03-23 11:37   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 20/77] irda: convert ks959 " Stephen Hemminger
2009-03-22  2:37   ` David Miller
2009-03-23 11:37   ` Samuel Ortiz
2009-03-21  5:35 ` [PATCH 21/77] usbnet: convert catc to internal net_device_stats Stephen Hemminger
2009-03-22  2:45   ` David Miller
2009-03-21  5:35 ` [PATCH 22/77] usbnet: convert catc device to net_device_ops Stephen Hemminger
2009-03-21  9:01   ` David Brownell
2009-03-21 13:02     ` Vojtech Pavlik
2009-03-21 10:17   ` Jiri Pirko
2009-03-22  2:40     ` David Miller
2009-03-22  2:45   ` David Miller
2009-03-21  5:35 ` [PATCH 23/77] usbnet: convert to internal net_device stats Stephen Hemminger
2009-03-21  9:01   ` David Brownell
2009-03-21 13:02     ` Vojtech Pavlik
2009-03-22  2:45   ` David Miller
2009-03-21  5:35 ` [PATCH 24/77] usbnet: convert rtl driver to net_device_ops Stephen Hemminger
2009-03-21  9:03   ` David Brownell
2009-03-23  9:17     ` Petko Manolov
2009-03-22  2:45   ` David Miller
2009-03-21  5:35 ` [PATCH 25/77] usbnet: convert hso " Stephen Hemminger
2009-03-21  9:08   ` David Brownell
2009-03-22  2:45   ` David Miller
2009-03-21  5:35 ` [PATCH 26/77] usbnet: convert to internal net_device_stats Stephen Hemminger
2009-03-21  9:09   ` David Brownell
2009-03-22  2:46   ` David Miller
2009-03-21  5:35 ` [PATCH 27/77] usbnet: support net_device_ops Stephen Hemminger
2009-03-21  9:11   ` David Brownell
2009-03-22  2:46   ` David Miller
2009-03-21  5:35 ` [PATCH 28/77] usbnet: convert asix driver to net_device_ops Stephen Hemminger
2009-03-21  9:12   ` David Brownell
2009-03-22  2:46   ` David Miller
2009-03-21  5:35 ` [PATCH 29/77] usbnet: convert dms9601 " Stephen Hemminger
2009-03-21  9:14   ` David Brownell
2009-03-21 10:57     ` Peter Korsgaard
2009-03-21 11:28       ` Peter Korsgaard
2009-03-22  3:00   ` David Miller
2009-03-21  5:35 ` [PATCH 30/77] usbnet: convert msc7830 " Stephen Hemminger
2009-03-21  9:19   ` David Brownell
2009-03-22  3:00   ` David Miller
2009-03-21  5:35 ` [PATCH 31/77] usbnet: convert sms95xx " Stephen Hemminger
2009-03-21  9:20   ` David Brownell
2009-03-21 15:53     ` Steve.Glendinning
2009-03-22  3:01   ` David Miller
2009-03-21  5:35 ` [PATCH 32/77] usbnet: convert rndis driver to use dev_get_stats Stephen Hemminger
2009-03-21  9:22   ` David Brownell
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 33/77] usbnet: convert rndis driver to net_device_ops Stephen Hemminger
2009-03-21  9:23   ` David Brownell
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 34/77] pcmcia: convert 3c589 " Stephen Hemminger
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 35/77] pcmcia: convert 3c574 " Stephen Hemminger
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 36/77] pcmcia: convert fmvj18x driver to internal net_device_stats Stephen Hemminger
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 37/77] pcmcia: convert fmvj18x driver to net_device_ops Stephen Hemminger
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 38/77] pcmcia: convert nmclan " Stephen Hemminger
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 39/77] pcnet: convert " Stephen Hemminger
2009-03-22  3:01   ` David Miller
2009-03-21  5:36 ` [PATCH 40/77] xir2cps: convert to internal net_device stats Stephen Hemminger
2009-03-22  3:02   ` David Miller
2009-03-21  5:36 ` [PATCH 41/77] xirc2ps: convert to net_device_ops Stephen Hemminger
2009-03-22  5:42   ` David Miller
2009-03-21  5:36 ` [PATCH 42/77] smc91c92: convert to internal net_device_stats Stephen Hemminger
2009-03-22  5:42   ` David Miller
2009-03-21  5:36 ` [PATCH 43/77] smc91c92: convert to net_device_ops Stephen Hemminger
2009-03-22  5:42   ` David Miller
2009-03-21  5:36 ` [PATCH 44/77] axnet: convert ot net_device_ops Stephen Hemminger
2009-03-22  5:42   ` David Miller
2009-03-21  5:36 ` [PATCH 45/77] x25_asy: convert to internal net_device_stats Stephen Hemminger
2009-03-22  5:42   ` David Miller
2009-03-21  5:36 ` [PATCH 46/77] x25_asy: convert to net_device_ops Stephen Hemminger
2009-03-22  5:43   ` David Miller
2009-03-21  5:36 ` [PATCH 47/77] dlci: convert to internal net_device_stats Stephen Hemminger
2009-03-22  5:43   ` David Miller
2009-03-21  5:36 ` [PATCH 48/77] dlci: convert to net_device_ops Stephen Hemminger
2009-03-22  5:43   ` David Miller
2009-03-21  5:36 ` [PATCH 49/77] cycx: " Stephen Hemminger
2009-03-22  5:43   ` David Miller
2009-03-21  5:36 ` [PATCH 50/77] lapbether: convert to internal net_device_stats Stephen Hemminger
2009-03-22  5:43   ` David Miller
2009-03-21  5:36 ` [PATCH 51/77] labether: convert to net_device_ops Stephen Hemminger
2009-03-22  5:47   ` David Miller
2009-03-21  5:36 ` [PATCH 52/77] sbni: use internal net_device_stats Stephen Hemminger
2009-03-22  5:47   ` David Miller
2009-03-21  5:36 ` [PATCH 53/77] sbni: convert to net_device_ops Stephen Hemminger
2009-03-22  5:47   ` David Miller
2009-03-21  5:36 ` [PATCH 54/77] netwave: convert to internal net_device_stats Stephen Hemminger
     [not found]   ` <20090321053716.656878050-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:47     ` David Miller
2009-03-21  5:36 ` [PATCH 55/77] netwave: convert to net_device_ops Stephen Hemminger
2009-03-22  5:48   ` David Miller
2009-03-21  5:36 ` [PATCH 56/77] strip: " Stephen Hemminger
2009-03-22  5:47   ` David Miller
2009-03-21  5:36 ` [PATCH 57/77] wavelan: convert to internal net_device_stats Stephen Hemminger
     [not found]   ` <20090321053716.884788530-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:47     ` David Miller
2009-03-21  5:36 ` [PATCH 58/77] wavelan: convert to net_device_ops Stephen Hemminger
2009-03-22  5:47   ` David Miller
2009-03-21  5:36 ` [PATCH 59/77] airo: " Stephen Hemminger
     [not found]   ` <20090321053717.048069302-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:48     ` David Miller
2009-03-21  5:36 ` [PATCH 60/77] atmel: " Stephen Hemminger
     [not found]   ` <20090321053717.126155878-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:48     ` David Miller
2009-03-21  5:36 ` [PATCH 61/77] raylan: " Stephen Hemminger
2009-03-22  5:53   ` David Miller
2009-03-21  5:36 ` [PATCH 62/77] wl3501: convert to internal net_device_stats Stephen Hemminger
2009-03-22  5:53   ` David Miller
2009-03-21  5:36 ` [PATCH 63/77] wl3501: convert to net_device_ops Stephen Hemminger
2009-03-22  5:53   ` David Miller
2009-03-21  5:36 ` [PATCH 64/77] zd1201: convert to internal net_device_stats Stephen Hemminger
     [not found]   ` <20090321053717.440414565-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:53     ` David Miller
2009-03-21  5:36 ` [PATCH 65/77] zd1201: convert to net_device_ops Stephen Hemminger
     [not found]   ` <20090321053717.514936473-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:53     ` David Miller
2009-03-21  5:36 ` [PATCH 66/77] mac80211_hwsim: convert to internal net_device_stats Stephen Hemminger
     [not found]   ` <20090321053717.601771143-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-21 11:08     ` Johannes Berg
2009-03-22  5:49       ` David Miller
2009-03-22  5:53     ` David Miller
2009-03-21  5:36 ` [PATCH 67/77] prism54: convert to net_device_ops Stephen Hemminger
     [not found]   ` <20090321053717.682860987-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:53     ` David Miller
2009-03-21  5:36 ` Stephen Hemminger [this message]
2009-03-22  5:53   ` [PATCH 68/77] prism54: convert to internal net_device_stats David Miller
2009-03-21  5:36 ` [PATCH 69/77] libertas: " Stephen Hemminger
2009-03-22  5:54   ` David Miller
2009-03-21  5:36 ` [PATCH 70/77] libertas: convert to net_device_ops Stephen Hemminger
2009-03-22  5:54   ` David Miller
2009-03-21  5:36 ` [PATCH 71/77] ipw2x00: convert to internal net_device_stats Stephen Hemminger
2009-03-22  5:56   ` David Miller
2009-03-21  5:36 ` [PATCH 72/77] ipw2x00: convert infrastructure for use by net_device_ops Stephen Hemminger
2009-03-22  5:56   ` David Miller
2009-03-21  5:36 ` [PATCH 73/77] ipw2100: convert to net_device_ops Stephen Hemminger
     [not found]   ` <20090321053718.145743314-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:57     ` David Miller
2009-03-21  5:36 ` [PATCH 74/77] ipw2200: " Stephen Hemminger
     [not found]   ` <20090321053718.224939952-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2009-03-22  5:57     ` David Miller
2009-03-21  5:36 ` [PATCH 75/77] hostap: convert to internal net_device_stats Stephen Hemminger
2009-03-22  5:57   ` David Miller
2009-03-21  5:36 ` [PATCH 76/77] hostap: convert to net_device_ops Stephen Hemminger
2009-03-22  5:57   ` David Miller
2009-03-21  5:36 ` [PATCH 77/77] netdev: expose net_device_ops compat as config option Stephen Hemminger
2009-03-22  5:57   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090321053717.765575826@vyatta.com \
    --to=shemminger-ztmgi6mnkb3qt0dzr+alfa@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mcgrof-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).