From: David Miller <davem@davemloft.net>
To: david-b@pacbell.net
Cc: netdev@vger.kernel.org
Subject: Re: [patch 2.6.29-rc8] dm9000 locking bugfix
Date: Sun, 22 Mar 2009 21:28:57 -0700 (PDT) [thread overview]
Message-ID: <20090322.212857.96030314.davem@davemloft.net> (raw)
In-Reply-To: <200903221612.13055.david-b@pacbell.net>
From: David Brownell <david-b@pacbell.net>
Date: Sun, 22 Mar 2009 16:12:12 -0700
> This fixes a locking bug in the dm9000 driver. It calls
> request_irq() without setting IRQF_DISABLED ... which is
> correct for handlers that support IRQ sharing, since that
> behavior is not guaranteed for shared IRQs. However, its
> IRQ handler then wrongly assumes that IRQs are blocked.
> So the fix just uses the right spinlock primitives in the
> IRQ handler.
>
> NOTE: this is a classic example of the type of bug which
> lockdep currently masks by forcibly setting IRQF_DISABLED
> on IRQ handlers that did not request that flag.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Applied, thanks.
prev parent reply other threads:[~2009-03-23 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 23:12 [patch 2.6.29-rc8] dm9000 locking bugfix David Brownell
2009-03-23 4:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090322.212857.96030314.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).