From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: mpm@selenic.com, marcin.slusarz@gmail.com,
netdev@vger.kernel.org, k-keiichi@bx.jp.nec.com,
stable@kernel.org, rjw@sisk.pl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netconsole: fix BUG during net device "upping"
Date: Mon, 23 Mar 2009 01:15:08 -0700 (PDT) [thread overview]
Message-ID: <20090323.011508.140910146.davem@davemloft.net> (raw)
In-Reply-To: <20090323081158.GB4976@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 23 Mar 2009 08:11:58 +0000
> On Mon, Mar 23, 2009 at 01:05:41AM -0700, David Miller wrote:
> > From: Jarek Poplawski <jarkao2@gmail.com>
> > Date: Mon, 23 Mar 2009 08:04:55 +0000
> >
> > > What is the rationale of this decision? printk is a basic tool,
> > > especially designed to work in as many places as possible, and
> > > netconsole is rather something secondary (sorry Matt)?!
> >
> > And this basic tool cannot work from the drivers ->open() method.
>
> And in any function used in the drivers ->open(). BTW, with Marcin's
> patch it can...
This issue came up before, and after we added the netif_running()
check we hit this IIF_UP one and at the time we looked into it
and the result we came up with is that you just can't do it in
a network driver's ->open()
Look up the thread, I'm too lazy...
next prev parent reply other threads:[~2009-03-23 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 11:02 [PATCH] netconsole: fix BUG during net device "upping" Marcin Slusarz
2009-03-23 1:20 ` Matt Mackall
2009-03-23 4:21 ` David Miller
2009-03-23 8:04 ` Jarek Poplawski
2009-03-23 8:05 ` David Miller
2009-03-23 8:11 ` Jarek Poplawski
2009-03-23 8:15 ` David Miller [this message]
2009-03-23 9:20 ` Jarek Poplawski
2009-03-24 8:22 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323.011508.140910146.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).