From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [PATCH] netconsole: fix BUG during net device "upping" Date: Mon, 23 Mar 2009 08:04:55 +0000 Message-ID: <20090323080455.GA4976@ff.dom.local> References: <20090322.212107.55546529.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mpm@selenic.com, marcin.slusarz@gmail.com, netdev@vger.kernel.org, k-keiichi@bx.jp.nec.com, stable@kernel.org, rjw@sisk.pl, linux-kernel@vger.kernel.org To: David Miller Return-path: Received: from mail-ew0-f165.google.com ([209.85.219.165]:63129 "EHLO mail-ew0-f165.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104AbZCWIFE (ORCPT ); Mon, 23 Mar 2009 04:05:04 -0400 Content-Disposition: inline In-Reply-To: <20090322.212107.55546529.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 23-03-2009 05:21, David Miller wrote: > From: Matt Mackall > Date: Sun, 22 Mar 2009 20:20:58 -0500 > >> On Sun, 2009-03-22 at 12:02 +0100, Marcin Slusarz wrote: >>> When ndo_open (eg skge_up) function printks something, netconsole decides >>> it can use this device because it checks state only (netif_running) which is >>> set before ndo_open. Check device flags too. >> That's fairly unfortunate semantics for netif_running. But if Dave >> agrees that it's reasonable for that to be set to true at this point in >> time, then I guess we'll go with it. > > These kind of printk's simply are not allowed, we've removed such > printk's from other driver ->open() methods to fix this problem and > that's what should be done here. What is the rationale of this decision? printk is a basic tool, especially designed to work in as many places as possible, and netconsole is rather something secondary (sorry Matt)?! Jarek P.